Re: [PATCH net] tun: fix recovery from gup errors

2013-06-25 Thread David Miller
From: Jason Wang Date: Mon, 24 Jun 2013 11:22:52 +0800 > On 06/23/2013 10:19 PM, Michael S. Tsirkin wrote: >> get user pages might fail partially in tun zero copy >> mode. To recover we need to put all pages that we got, >> but code used a wrong index resulting in double-free >> errors. >> >> Rep

Re: [PATCH net] tun: fix recovery from gup errors

2013-06-24 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 24 Jun 2013 15:54:12 +0300 > On Sun, Jun 23, 2013 at 07:36:21PM +0400, Sergei Shtylyov wrote: >> Hello. >> >> On 23-06-2013 18:19, Michael S. Tsirkin wrote: >> >> >get user pages might fail partially in tun zero copy >> >mode. To recover we need to put all

Re: [PATCH net] tun: fix recovery from gup errors

2013-06-24 Thread Michael S. Tsirkin
On Sun, Jun 23, 2013 at 07:36:21PM +0400, Sergei Shtylyov wrote: > Hello. > > On 23-06-2013 18:19, Michael S. Tsirkin wrote: > > >get user pages might fail partially in tun zero copy > >mode. To recover we need to put all pages that we got, > >but code used a wrong index resulting in double-free

Re: [PATCH net] tun: fix recovery from gup errors

2013-06-24 Thread Neil Horman
On Sun, Jun 23, 2013 at 05:19:03PM +0300, Michael S. Tsirkin wrote: > get user pages might fail partially in tun zero copy > mode. To recover we need to put all pages that we got, > but code used a wrong index resulting in double-free > errors. > > Reported-by: Brad Hubbard > Signed-off-by: Micha

Re: [PATCH net] tun: fix recovery from gup errors

2013-06-23 Thread Jason Wang
On 06/23/2013 10:19 PM, Michael S. Tsirkin wrote: > get user pages might fail partially in tun zero copy > mode. To recover we need to put all pages that we got, > but code used a wrong index resulting in double-free > errors. > > Reported-by: Brad Hubbard > Signed-off-by: Michael S. Tsirkin > --

Re: [PATCH net] tun: fix recovery from gup errors

2013-06-23 Thread Sergei Shtylyov
Hello. On 23-06-2013 18:19, Michael S. Tsirkin wrote: get user pages might fail partially in tun zero copy mode. To recover we need to put all pages that we got, but code used a wrong index resulting in double-free errors. Reported-by: Brad Hubbard Signed-off-by: Michael S. Tsirkin ---