Re: [PATCH net] mvpp2: refactor MTU change code

2019-07-27 Thread David Miller
From: Matteo Croce Date: Fri, 26 Jul 2019 01:19:31 +0200 > The MTU change code can call napi_disable() with the device already down, > leading to a deadlock. Also, lot of code is duplicated unnecessarily. > > Rework mvpp2_change_mtu() to avoid the deadlock and remove duplicated code. > > Signed

Re: [PATCH net] mvpp2: refactor MTU change code

2019-07-26 Thread Matteo Croce
On Fri, Jul 26, 2019 at 2:50 PM Antoine Tenart wrote: > > Hi Matteo, > > On Fri, Jul 26, 2019 at 01:19:31AM +0200, Matteo Croce wrote: > > The MTU change code can call napi_disable() with the device already down, > > leading to a deadlock. Also, lot of code is duplicated unnecessarily. > > > > Rew

Re: [PATCH net] mvpp2: refactor MTU change code

2019-07-26 Thread Antoine Tenart
Hi Matteo, On Fri, Jul 26, 2019 at 01:19:31AM +0200, Matteo Croce wrote: > The MTU change code can call napi_disable() with the device already down, > leading to a deadlock. Also, lot of code is duplicated unnecessarily. > > Rework mvpp2_change_mtu() to avoid the deadlock and remove duplicated co