Re: [PATCH mmotm] memcg: further prevent OOM with too many dirty pages

2012-07-16 Thread Michal Hocko
On Mon 16-07-12 21:52:51, Hugh Dickins wrote: > On Mon, 16 Jul 2012, Michal Hocko wrote: > > On Mon 16-07-12 01:35:34, Hugh Dickins wrote: > > > But even so, the test still OOMs sometimes: when originally testing > > > on 3.5-rc6, it OOMed about one time in five or ten; when testing > > > just now

Re: [PATCH mmotm] memcg: further prevent OOM with too many dirty pages

2012-07-16 Thread Hugh Dickins
On Mon, 16 Jul 2012, Michal Hocko wrote: > On Mon 16-07-12 01:35:34, Hugh Dickins wrote: > > But even so, the test still OOMs sometimes: when originally testing > > on 3.5-rc6, it OOMed about one time in five or ten; when testing > > just now on 3.5-rc6-mm1, it OOMed on the first iteration. > > >

Re: [PATCH mmotm] memcg: further prevent OOM with too many dirty pages

2012-07-16 Thread Andrew Morton
On Mon, 16 Jul 2012 01:35:34 -0700 (PDT) Hugh Dickins wrote: > Incremental on top of what I believe you presently have in mmotm: > better folded in on top of Michal's original and the may_enter_fs "fix". I think I'll keep it as a separate patch, actually. This is a pretty tricky and error-prone

Re: [PATCH mmotm] memcg: further prevent OOM with too many dirty pages

2012-07-16 Thread Michal Hocko
On Mon 16-07-12 01:35:34, Hugh Dickins wrote: > The may_enter_fs test turns out to be too restrictive: though I saw > no problem with it when testing on 3.5-rc6, it very soon OOMed when > I tested on 3.5-rc6-mm1. I don't know what the difference there is, > perhaps I just slightly changed the way