Re: [PATCH mm] cfag12864b: fix crash when built-in and no parport present

2007-02-13 Thread Miguel Ojeda
On 2/13/07, Daniel Walker <[EMAIL PROTECTED]> wrote: On Mon, 2007-02-12 at 21:35 -0800, Andrew Morton wrote: > > This looks hacky. > One other thing that could be added is a change in the initcalls . ks0108 should be subsys_initcall() and the LCD devices device_initcall(). That would make sure

Re: [PATCH mm] cfag12864b: fix crash when built-in and no parport present

2007-02-13 Thread Daniel Walker
On Mon, 2007-02-12 at 21:35 -0800, Andrew Morton wrote: > > This looks hacky. > One other thing that could be added is a change in the initcalls . ks0108 should be subsys_initcall() and the LCD devices device_initcall(). That would make sure one runs before the other. I don't think that alone w

Re: [PATCH mm] cfag12864b: fix crash when built-in and no parport present

2007-02-12 Thread Miguel Ojeda
On 2/13/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Sat, 10 Feb 2007 20:51:23 +0100 Miguel Ojeda <[EMAIL PROTECTED]> wrote: > Andrew, Daniel who reported the crash has tested this patch and says that it works fine avoiding it, so you can merge. > > drivers-add-lcd-support-fix-crash-when-buil

Re: [PATCH mm] cfag12864b: fix crash when built-in and no parport present

2007-02-12 Thread Andrew Morton
On Sat, 10 Feb 2007 20:51:23 +0100 Miguel Ojeda <[EMAIL PROTECTED]> wrote: > Andrew, Daniel who reported the crash has tested this patch and says that it > works fine avoiding it, so you can merge. > > drivers-add-lcd-support-fix-crash-when-built-in-and-no-parport-present.patch > Signed-off-by:

Re: [PATCH mm] cfag12864b: fix crash when built-in and no parport present

2007-02-12 Thread Daniel Walker
On Sat, 2007-02-10 at 20:51 +0100, Miguel Ojeda wrote: > Andrew, Daniel who reported the crash has tested this patch and says that it > works fine avoiding it, so you can merge. > Yes, I tested it with the ks0108 enabled alone, and with both ks0108 and CFAG12864B .. Both booted fully.. Daniel