Re: [PATCH cifs-next] fs: cifs: make smb_echo_interval tunable

2012-11-09 Thread Jeff Layton
On Fri, 09 Nov 2012 09:40:37 -0600 Chris J Arges wrote: > > > > I'm not so sure I like making this tunable... > > > Ok, I saw the 'FIXME: tunable?', and thought this was something that > could be exposed as a parameter in the future. > Yeah, when I originally wrote that code I put that commen

Re: [PATCH cifs-next] fs: cifs: make smb_echo_interval tunable

2012-11-09 Thread Chris J Arges
On 11/09/2012 05:00 AM, Jeff Layton wrote: > On Thu, 8 Nov 2012 14:50:28 -0600 > Chris J Arges wrote: > >> Change SMB_ECHO_INTERVAL to make it a module parameter. >> >> BugLink: http://bugs.launchpad.net/bugs/1017622 >> BugLink: https://bugzilla.samba.org/show_bug.cgi?id=9006 >> > > It's custom

Re: [PATCH cifs-next] fs: cifs: make smb_echo_interval tunable

2012-11-09 Thread Jeff Layton
On Thu, 8 Nov 2012 14:50:28 -0600 Chris J Arges wrote: > Change SMB_ECHO_INTERVAL to make it a module parameter. > > BugLink: http://bugs.launchpad.net/bugs/1017622 > BugLink: https://bugzilla.samba.org/show_bug.cgi?id=9006 > It's customary to write up the reason for a change in the bug descr