Re: [PATCH V7 04/15] kprobes: Add perf ksymbol events for kprobe insn pages

2020-05-28 Thread Adrian Hunter
On 27/05/20 8:20 pm, Peter Zijlstra wrote: > On Wed, May 27, 2020 at 06:17:32PM +0200, Peter Zijlstra wrote: >> On Tue, May 12, 2020 at 03:19:11PM +0300, Adrian Hunter wrote: >>> @@ -202,6 +207,13 @@ static int collect_one_slot(struct kprobe_insn_page >>> *kip, int idx) >>> * next tim

Re: [PATCH V7 04/15] kprobes: Add perf ksymbol events for kprobe insn pages

2020-05-27 Thread Peter Zijlstra
On Wed, May 27, 2020 at 06:17:32PM +0200, Peter Zijlstra wrote: > On Tue, May 12, 2020 at 03:19:11PM +0300, Adrian Hunter wrote: > > @@ -202,6 +207,13 @@ static int collect_one_slot(struct kprobe_insn_page > > *kip, int idx) > > * next time somebody inserts a probe. > > *

Re: [PATCH V7 04/15] kprobes: Add perf ksymbol events for kprobe insn pages

2020-05-27 Thread Peter Zijlstra
On Tue, May 12, 2020 at 03:19:11PM +0300, Adrian Hunter wrote: > @@ -202,6 +207,13 @@ static int collect_one_slot(struct kprobe_insn_page > *kip, int idx) >* next time somebody inserts a probe. >*/ > if (!list_is_singular(&kip->list)) { > +