Re: [PATCH V6 07/33] csky: MMU and page table management

2018-09-29 Thread Guo Ren
On Thu, Sep 27, 2018 at 08:47:33AM -0700, Christoph Hellwig wrote: > > +static void *csky_dma_alloc_atomic( > > + struct device *dev, > > + size_t size, > > + dma_addr_t *dma_handle > > + ) > > Can you please use normal kernel coding style? Closing brace on the > same line, either two tab

Re: [PATCH V6 07/33] csky: MMU and page table management

2018-09-28 Thread Guo Ren
On Thu, Sep 27, 2018 at 08:47:33AM -0700, Christoph Hellwig wrote: > > +static void *csky_dma_alloc_atomic( > > + struct device *dev, > > + size_t size, > > + dma_addr_t *dma_handle > > + ) > > Can you please use normal kernel coding style? Closing brace on the > same line, either two tab

Re: [PATCH V6 07/33] csky: MMU and page table management

2018-09-27 Thread Christoph Hellwig
> +static void *csky_dma_alloc_atomic( > + struct device *dev, > + size_t size, > + dma_addr_t *dma_handle > + ) Can you please use normal kernel coding style? Closing brace on the same line, either two tab indents for the arguments or align them to the first argument: static voi