Re: [PATCH V32 27/27] tracefs: Restrict tracefs when the kernel is locked down

2019-04-04 Thread Matthew Garrett
On Thu, Apr 4, 2019 at 6:39 AM Steven Rostedt wrote: > > On Wed, 3 Apr 2019 17:32:49 -0700 > Matthew Garrett wrote: > > > > +static void tracefs_destroy_inode(struct inode *inode) > > +{ > > + if S_ISREG(inode->i_mode) > > Can we please put parenthesis around the condition. I know that the >

Re: [PATCH V32 27/27] tracefs: Restrict tracefs when the kernel is locked down

2019-04-04 Thread Steven Rostedt
On Wed, 3 Apr 2019 17:32:49 -0700 Matthew Garrett wrote: > +static void tracefs_destroy_inode(struct inode *inode) > +{ > + if S_ISREG(inode->i_mode) Can we please put parenthesis around the condition. I know that the macro has them, but no other place in the kernel plays such a trick.