Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference

2020-12-17 Thread Thomas Gleixner
On Mon, Nov 23 2020 at 22:09, ira weiny wrote: > From: Ira Weiny > > Currently struct irqentry_state_t only contains a single bool value > which makes passing it by value is reasonable. However, future patches > add information to this struct. This includes the PKRS thread state, > included in t

Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference

2020-12-17 Thread Andy Lutomirski
> On Dec 17, 2020, at 5:19 AM, Peter Zijlstra wrote: > > On Thu, Dec 17, 2020 at 02:07:01PM +0100, Thomas Gleixner wrote: >>> On Fri, Dec 11 2020 at 14:14, Andy Lutomirski wrote: On Mon, Nov 23, 2020 at 10:10 PM wrote: >>> After contemplating this for a bit, I think this isn't really the

Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference

2020-12-17 Thread Peter Zijlstra
On Thu, Dec 17, 2020 at 02:07:01PM +0100, Thomas Gleixner wrote: > On Fri, Dec 11 2020 at 14:14, Andy Lutomirski wrote: > > On Mon, Nov 23, 2020 at 10:10 PM wrote: > > After contemplating this for a bit, I think this isn't really the > > right approach. It *works*, but we've mostly just created a

Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference

2020-12-17 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 14:14, Andy Lutomirski wrote: > On Mon, Nov 23, 2020 at 10:10 PM wrote: > After contemplating this for a bit, I think this isn't really the > right approach. It *works*, but we've mostly just created a bit of an > unfortunate situation. Our stack, on a (possibly nested) en

Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference

2020-12-16 Thread Ira Weiny
On Tue, Dec 15, 2020 at 06:09:02PM -0800, Andy Lutomirski wrote: > On Tue, Dec 15, 2020 at 5:32 PM Ira Weiny wrote: > > > > On Fri, Dec 11, 2020 at 02:14:28PM -0800, Andy Lutomirski wrote: > > > On Mon, Nov 23, 2020 at 10:10 PM wrote: > > > > IOW we have: > > > > > > struct extended_pt_regs { >

Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference

2020-12-15 Thread Andy Lutomirski
On Tue, Dec 15, 2020 at 5:32 PM Ira Weiny wrote: > > On Fri, Dec 11, 2020 at 02:14:28PM -0800, Andy Lutomirski wrote: > > On Mon, Nov 23, 2020 at 10:10 PM wrote: > > IOW we have: > > > > struct extended_pt_regs { > > bool rcu_whatever; > > other generic fields here; > > struct arch_extende

Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference

2020-12-15 Thread Ira Weiny
On Fri, Dec 11, 2020 at 02:14:28PM -0800, Andy Lutomirski wrote: > On Mon, Nov 23, 2020 at 10:10 PM wrote: > > > > From: Ira Weiny > > > > Currently struct irqentry_state_t only contains a single bool value > > which makes passing it by value is reasonable. However, future patches > > add inform

Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference

2020-12-11 Thread Andy Lutomirski
On Mon, Nov 23, 2020 at 10:10 PM wrote: > > From: Ira Weiny > > Currently struct irqentry_state_t only contains a single bool value > which makes passing it by value is reasonable. However, future patches > add information to this struct. This includes the PKRS thread state, > included in this