Re: [PATCH V3] thermal: Add cooling device's statistics in sysfs

2018-01-16 Thread Viresh Kumar
On 15-01-18, 08:32, Eduardo Valentin wrote: > Same set you added for cooling devices should also be reflected on > thermal zones, but instead of cooling state, you want to do the account > on trips, at least for the context of this patch set. I never dived deep into the thermal core earlier and ne

Re: [PATCH V3] thermal: Add cooling device's statistics in sysfs

2018-01-16 Thread Viresh Kumar
On 15-01-18, 08:32, Eduardo Valentin wrote: > On Mon, Jan 15, 2018 at 10:16:16AM +0530, Viresh Kumar wrote: > > No because I am exiting early for same sates in that routine. > > Did I miss that hunk? Yes. It is something like this. + if (stats->state == new_state) + goto unlo

Re: [PATCH V3] thermal: Add cooling device's statistics in sysfs

2018-01-15 Thread Eduardo Valentin
On Mon, Jan 15, 2018 at 10:16:16AM +0530, Viresh Kumar wrote: > On 12-01-18, 09:46, Eduardo Valentin wrote: > > On Thu, Jan 11, 2018 at 03:06:09PM +0530, Viresh Kumar wrote: > > > $ ls -R /sys/class/thermal/cooling_device0/ > > > /sys/class/thermal/cooling_device0/: > > > cur_state max_state powe

Re: [PATCH V3] thermal: Add cooling device's statistics in sysfs

2018-01-14 Thread Viresh Kumar
On 12-01-18, 09:46, Eduardo Valentin wrote: > On Thu, Jan 11, 2018 at 03:06:09PM +0530, Viresh Kumar wrote: > > $ ls -R /sys/class/thermal/cooling_device0/ > > /sys/class/thermal/cooling_device0/: > > cur_state max_state power stats subsystem type uevent > > > > /sys/class/thermal/cooling_de

Re: [PATCH V3] thermal: Add cooling device's statistics in sysfs

2018-01-12 Thread Eduardo Valentin
Hello, On Thu, Jan 11, 2018 at 03:06:09PM +0530, Viresh Kumar wrote: > This extends the sysfs interface for thermal cooling devices and exposes > some pretty useful statistics. These statistics have proven to be quite > useful specially while doing benchmarks related to the task scheduler, > where

Re: [PATCH V3] thermal: Add cooling device's statistics in sysfs

2018-01-12 Thread Eduardo Valentin
On Fri, Jan 12, 2018 at 04:39:43PM +0530, Aishwarya Pant wrote: > On Thu, Jan 11, 2018 at 03:06:09PM +0530, Viresh Kumar wrote: > > This extends the sysfs interface for thermal cooling devices and exposes > > some pretty useful statistics. These statistics have proven to be quite > > useful special

Re: [PATCH V3] thermal: Add cooling device's statistics in sysfs

2018-01-12 Thread Aishwarya Pant
On Thu, Jan 11, 2018 at 03:06:09PM +0530, Viresh Kumar wrote: > This extends the sysfs interface for thermal cooling devices and exposes > some pretty useful statistics. These statistics have proven to be quite > useful specially while doing benchmarks related to the task scheduler, > where we want