Re: [PATCH V3] Input: pm8941-pwrkey: add resin key capabilities

2018-05-15 Thread Dmitry Torokhov
On Mon, May 07, 2018 at 11:46:59AM -0700, Bjorn Andersson wrote: > On Fri 04 May 17:10 PDT 2018, Dmitry Torokhov wrote: > > > Hi Tirupathi, > > > > On Fri, Mar 23, 2018 at 11:53:12AM +0530, Tirupathi Reddy wrote: > > > Add resin key support to handle different types of key events > > > defined in

Re: [PATCH V3] Input: pm8941-pwrkey: add resin key capabilities

2018-05-07 Thread Bjorn Andersson
On Fri 04 May 17:10 PDT 2018, Dmitry Torokhov wrote: > Hi Tirupathi, > > On Fri, Mar 23, 2018 at 11:53:12AM +0530, Tirupathi Reddy wrote: > > Add resin key support to handle different types of key events > > defined in different platforms. > > > > Signed-off-by: Tirupathi Reddy > > --- > > ...

Re: [PATCH V3] Input: pm8941-pwrkey: add resin key capabilities

2018-05-04 Thread Dmitry Torokhov
Hi Tirupathi, On Fri, Mar 23, 2018 at 11:53:12AM +0530, Tirupathi Reddy wrote: > Add resin key support to handle different types of key events > defined in different platforms. > > Signed-off-by: Tirupathi Reddy > --- > .../bindings/input/qcom,pm8941-pwrkey.txt | 32 + > driver

Re: [PATCH V3] Input: pm8941-pwrkey: add resin key capabilities

2018-03-26 Thread Rob Herring
On Fri, Mar 23, 2018 at 11:53:12AM +0530, Tirupathi Reddy wrote: > Add resin key support to handle different types of key events > defined in different platforms. > > Signed-off-by: Tirupathi Reddy > --- > .../bindings/input/qcom,pm8941-pwrkey.txt | 32 + Reviewed-by: Rob Herrin

Re: [PATCH V3] Input: pm8941-pwrkey: add resin key capabilities

2018-03-23 Thread Trilok Soni
Hi Dmitry, What happens if interrupts comes as soon as you have done the key_init(..) here? I see that you are registering the input device after it, right? Looks like you should do this at the end of probe? It should be fine, input devices properly allocated (with input_allocate_device() or

Re: [PATCH V3] Input: pm8941-pwrkey: add resin key capabilities

2018-03-23 Thread Dmitry Torokhov
On Fri, Mar 23, 2018 at 12:14:22PM -0700, Trilok Soni wrote: > Hi Tirupathi, > > > +static irqreturn_t pm8941_resinkey_irq(int irq, void *_data) > > +{ > > + struct pm8941_pwrkey *pwrkey = _data; > > + unsigned int sts; > > + int error; > > + u32 key_code = pwrkey->resin_key_code; > > + >

Re: [PATCH V3] Input: pm8941-pwrkey: add resin key capabilities

2018-03-23 Thread Trilok Soni
Hi Tirupathi, +static irqreturn_t pm8941_resinkey_irq(int irq, void *_data) +{ + struct pm8941_pwrkey *pwrkey = _data; + unsigned int sts; + int error; + u32 key_code = pwrkey->resin_key_code; + + error = regmap_read(pwrkey->regmap, + pw