Re: [PATCH V2 3/3] pinctrl: Add Pistachio SoC pin control driver

2015-04-07 Thread Linus Walleij
On Tue, Mar 31, 2015 at 6:56 PM, Andrew Bresticker wrote: > Hi Paul, > > On Tue, Mar 31, 2015 at 1:10 AM, Paul Bolle wrote: >> The patch adds a mismatch between the Kconfig symbol (a bool) and the >> code (which suggests that a modular build is also possible). > > Nearly all of the pinctrl driver

Re: [PATCH V2 3/3] pinctrl: Add Pistachio SoC pin control driver

2015-03-31 Thread Paul Bolle
Hi Andrew, On Tue, 2015-03-31 at 11:37 -0700, Andrew Bresticker wrote: > I have no immediate plans to make this a module, but since the changes > to make it buildable as a module have no overhead (at least I think > they don't!) I'd prefer to leave them in for consistency and to > eliminate any ne

Re: [PATCH V2 3/3] pinctrl: Add Pistachio SoC pin control driver

2015-03-31 Thread Andrew Bresticker
Hi Paul, On Tue, Mar 31, 2015 at 11:20 AM, Paul Bolle wrote: > Hi Andrew, > > On Tue, 2015-03-31 at 09:56 -0700, Andrew Bresticker wrote: >> On Tue, Mar 31, 2015 at 1:10 AM, Paul Bolle wrote: >> > The patch adds a mismatch between the Kconfig symbol (a bool) and the >> > code (which suggests tha

Re: [PATCH V2 3/3] pinctrl: Add Pistachio SoC pin control driver

2015-03-31 Thread Paul Bolle
Hi Andrew, On Tue, 2015-03-31 at 09:56 -0700, Andrew Bresticker wrote: > On Tue, Mar 31, 2015 at 1:10 AM, Paul Bolle wrote: > > The patch adds a mismatch between the Kconfig symbol (a bool) and the > > code (which suggests that a modular build is also possible). > > Nearly all of the pinctrl dri

Re: [PATCH V2 3/3] pinctrl: Add Pistachio SoC pin control driver

2015-03-31 Thread Andrew Bresticker
Hi Paul, On Tue, Mar 31, 2015 at 1:10 AM, Paul Bolle wrote: > The patch adds a mismatch between the Kconfig symbol (a bool) and the > code (which suggests that a modular build is also possible). Nearly all of the pinctrl drivers (with the exception of qcom and intel) are like this. They use a b

Re: [PATCH V2 3/3] pinctrl: Add Pistachio SoC pin control driver

2015-03-31 Thread Paul Bolle
The patch adds a mismatch between the Kconfig symbol (a bool) and the code (which suggests that a modular build is also possible). On Mon, 2015-03-30 at 16:16 -0700, Andrew Bresticker wrote: > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > +config PINCTRL_PISTACHIO > + def_bo