Re: [PATCH V2 3/3] PCI: Add helpers to enable/disable CXL.mem and CXL.cache

2020-05-20 Thread Christoph Hellwig
On Mon, May 18, 2020 at 09:35:23AM -0700, Sean V Kelley wrote: > With these helpers, a device driver can enable/disable access to > CXL.mem and CXL.cache. Note that the device driver is responsible for > managing the memory area. Who is going to call these? Please don't submit new APIs without us

Re: [PATCH V2 3/3] PCI: Add helpers to enable/disable CXL.mem and CXL.cache

2020-05-19 Thread Sean V Kelley
On 18 May 2020, at 9:55, Bjorn Helgaas wrote: On Mon, May 18, 2020 at 09:35:23AM -0700, Sean V Kelley wrote: With these helpers, a device driver can enable/disable access to CXL.mem and CXL.cache. Note that the device driver is responsible for managing the memory area. Signed-off-by: Sean V Ke

Re: [PATCH V2 3/3] PCI: Add helpers to enable/disable CXL.mem and CXL.cache

2020-05-18 Thread kbuild test robot
Hi Sean, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pci/next] [also build test WARNING on v5.7-rc6 next-20200518] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option

Re: [PATCH V2 3/3] PCI: Add helpers to enable/disable CXL.mem and CXL.cache

2020-05-18 Thread kbuild test robot
Hi Sean, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pci/next] [also build test WARNING on v5.7-rc6 next-20200518] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option

Re: [PATCH V2 3/3] PCI: Add helpers to enable/disable CXL.mem and CXL.cache

2020-05-18 Thread Bjorn Helgaas
On Mon, May 18, 2020 at 09:35:23AM -0700, Sean V Kelley wrote: > With these helpers, a device driver can enable/disable access to > CXL.mem and CXL.cache. Note that the device driver is responsible for > managing the memory area. > > Signed-off-by: Sean V Kelley > --- > drivers/pci/cxl.c | 93 ++