Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-03 Thread Shi, Yang
On 12/3/2015 11:06 AM, Steven Rostedt wrote: On Thu, 03 Dec 2015 10:36:18 -0800 "Shi, Yang" wrote: called directly that calls these functions internally and the tracepoint can trap the return value. This will incur more changes in other subsystems (futex, kvm, etc), I'm not sure if it is wor

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-03 Thread Steven Rostedt
On Thu, 03 Dec 2015 10:36:18 -0800 "Shi, Yang" wrote: > > called directly that calls these functions internally and the tracepoint > > can trap the return value. > > This will incur more changes in other subsystems (futex, kvm, etc), I'm > not sure if it is worth making such changes to get re

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-03 Thread Shi, Yang
On 12/2/2015 8:13 PM, Steven Rostedt wrote: On Wed, 2 Dec 2015 15:36:50 -0800 Dave Hansen wrote: On 12/02/2015 02:53 PM, Yang Shi wrote: diff --git a/mm/gup.c b/mm/gup.c index deafa2c..10245a4 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -13,6 +13,9 @@ #include #include +#define CREATE_TRAC

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-02 Thread Steven Rostedt
On Wed, 2 Dec 2015 15:36:50 -0800 Dave Hansen wrote: > On 12/02/2015 02:53 PM, Yang Shi wrote: > > diff --git a/mm/gup.c b/mm/gup.c > > index deafa2c..10245a4 100644 > > --- a/mm/gup.c > > +++ b/mm/gup.c > > @@ -13,6 +13,9 @@ > > #include > > #include > > > > +#define CREATE_TRACE_POINTS >

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-02 Thread Shi, Yang
On 12/2/2015 4:11 PM, Shi, Yang wrote: On 12/2/2015 3:36 PM, Dave Hansen wrote: On 12/02/2015 02:53 PM, Yang Shi wrote: diff --git a/mm/gup.c b/mm/gup.c index deafa2c..10245a4 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -13,6 +13,9 @@ #include #include +#define CREATE_TRACE_POINTS +#include

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-02 Thread Shi, Yang
On 12/2/2015 3:36 PM, Dave Hansen wrote: On 12/02/2015 02:53 PM, Yang Shi wrote: diff --git a/mm/gup.c b/mm/gup.c index deafa2c..10245a4 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -13,6 +13,9 @@ #include #include +#define CREATE_TRACE_POINTS +#include + #include #include This needs

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-02 Thread Dave Hansen
On 12/02/2015 02:53 PM, Yang Shi wrote: > diff --git a/mm/gup.c b/mm/gup.c > index deafa2c..10245a4 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -13,6 +13,9 @@ > #include > #include > > +#define CREATE_TRACE_POINTS > +#include > + > #include > #include This needs to be _the_ last thing