Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-17 Thread David Hildenbrand
On 17.10.19 09:34, Michal Hocko wrote: On Thu 17-10-19 09:21:24, David Hildenbrand wrote: On 17.10.19 09:11, Michal Hocko wrote: On Thu 17-10-19 10:44:41, Anshuman Khandual wrote: [...] Does this add-on documentation look okay ? Should we also mention about the possible reduction in chances of

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-17 Thread Michal Hocko
On Thu 17-10-19 09:21:24, David Hildenbrand wrote: > On 17.10.19 09:11, Michal Hocko wrote: > > On Thu 17-10-19 10:44:41, Anshuman Khandual wrote: > > [...] > > > Does this add-on documentation look okay ? Should we also mention about > > > the > > > possible reduction in chances of success during

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-17 Thread David Hildenbrand
On 17.10.19 09:11, Michal Hocko wrote: On Thu 17-10-19 10:44:41, Anshuman Khandual wrote: [...] Does this add-on documentation look okay ? Should we also mention about the possible reduction in chances of success during pfn block search for the non-power-of-two cases as the implicit alignment wi

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-17 Thread Michal Hocko
On Thu 17-10-19 10:44:41, Anshuman Khandual wrote: [...] > Does this add-on documentation look okay ? Should we also mention about the > possible reduction in chances of success during pfn block search for the > non-power-of-two cases as the implicit alignment will probably turn out to > be bigger

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread Anshuman Khandual
On 10/16/2019 10:18 PM, David Hildenbrand wrote: > On 16.10.19 17:31, Anshuman Khandual wrote: >> >> >> On 10/16/2019 06:11 PM, Michal Hocko wrote: >>> On Wed 16-10-19 14:29:05, David Hildenbrand wrote: On 16.10.19 13:51, Michal Hocko wrote: > On Wed 16-10-19 16:43:57, Anshuman Khandual

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread Anshuman Khandual
On 10/17/2019 06:20 AM, Mike Kravetz wrote: > On 10/16/19 4:02 AM, Anshuman Khandual wrote: >> HugeTLB helper alloc_gigantic_page() implements fairly generic allocation >> method where it scans over various zones looking for a large contiguous pfn >> range before trying to allocate it with alloc

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread Mike Kravetz
On 10/16/19 4:02 AM, Anshuman Khandual wrote: > HugeTLB helper alloc_gigantic_page() implements fairly generic allocation > method where it scans over various zones looking for a large contiguous pfn > range before trying to allocate it with alloc_contig_range(). Other than > deriving the requested

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread David Hildenbrand
On 16.10.19 17:31, Anshuman Khandual wrote: On 10/16/2019 06:11 PM, Michal Hocko wrote: On Wed 16-10-19 14:29:05, David Hildenbrand wrote: On 16.10.19 13:51, Michal Hocko wrote: On Wed 16-10-19 16:43:57, Anshuman Khandual wrote: On 10/16/2019 04:39 PM, David Hildenbrand wrote: [...] Jus

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread Michal Hocko
On Wed 16-10-19 21:01:19, Anshuman Khandual wrote: > > > On 10/16/2019 06:11 PM, Michal Hocko wrote: > > On Wed 16-10-19 14:29:05, David Hildenbrand wrote: > >> On 16.10.19 13:51, Michal Hocko wrote: > >>> On Wed 16-10-19 16:43:57, Anshuman Khandual wrote: > > > On 10/16/2019 04:39

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread Anshuman Khandual
On 10/16/2019 06:11 PM, Michal Hocko wrote: > On Wed 16-10-19 14:29:05, David Hildenbrand wrote: >> On 16.10.19 13:51, Michal Hocko wrote: >>> On Wed 16-10-19 16:43:57, Anshuman Khandual wrote: On 10/16/2019 04:39 PM, David Hildenbrand wrote: >>> [...] > Just to make sure, you

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread Michal Hocko
On Wed 16-10-19 14:29:05, David Hildenbrand wrote: > On 16.10.19 13:51, Michal Hocko wrote: > > On Wed 16-10-19 16:43:57, Anshuman Khandual wrote: > > > > > > > > > On 10/16/2019 04:39 PM, David Hildenbrand wrote: > > [...] > > > > Just to make sure, you ignored my comment regarding alignment > >

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread David Hildenbrand
On 16.10.19 13:51, Michal Hocko wrote: On Wed 16-10-19 16:43:57, Anshuman Khandual wrote: On 10/16/2019 04:39 PM, David Hildenbrand wrote: [...] Just to make sure, you ignored my comment regarding alignment although I explicitly mentioned it a second time? Thanks. I had asked Michal explic

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread Michal Hocko
On Wed 16-10-19 16:43:57, Anshuman Khandual wrote: > > > On 10/16/2019 04:39 PM, David Hildenbrand wrote: [...] > > Just to make sure, you ignored my comment regarding alignment > > although I explicitly mentioned it a second time? Thanks. > > I had asked Michal explicitly what to be included fo

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread Anshuman Khandual
On 10/16/2019 04:39 PM, David Hildenbrand wrote: > On 16.10.19 13:02, Anshuman Khandual wrote: >> HugeTLB helper alloc_gigantic_page() implements fairly generic allocation >> method where it scans over various zones looking for a large contiguous pfn >> range before trying to allocate it with al

Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages()

2019-10-16 Thread David Hildenbrand
On 16.10.19 13:02, Anshuman Khandual wrote: HugeTLB helper alloc_gigantic_page() implements fairly generic allocation method where it scans over various zones looking for a large contiguous pfn range before trying to allocate it with alloc_contig_range(). Other than deriving the requested order f