Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-12 Thread Shengjiu Wang
On Fri, Sep 12, 2014 at 10:54:46AM +0200, Markus Pargmann wrote: > On Fri, Sep 12, 2014 at 03:14:28PM +0800, Shengjiu Wang wrote: > > On Fri, Sep 12, 2014 at 08:17:06AM +0200, Markus Pargmann wrote: > > > Hi, > > > > > > On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote: > > > > On Thu

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-12 Thread Markus Pargmann
On Fri, Sep 12, 2014 at 03:14:28PM +0800, Shengjiu Wang wrote: > On Fri, Sep 12, 2014 at 08:17:06AM +0200, Markus Pargmann wrote: > > Hi, > > > > On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote: > > > On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote: > > > > On Thu, Sep 1

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-12 Thread Shengjiu Wang
On Fri, Sep 12, 2014 at 08:17:06AM +0200, Markus Pargmann wrote: > Hi, > > On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote: > > On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote: > > > On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote: > > > > Move the ipg cloc

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-11 Thread Markus Pargmann
Hi, On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote: > On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote: > > On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote: > > > Move the ipg clock enable and disable operation to startup and shutdown, > > > that is only en

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-11 Thread Shengjiu Wang
On Thu, Sep 11, 2014 at 09:43:59PM -0500, Timur Tabi wrote: > Shengjiu Wang wrote: > >+ret = clk_prepare_enable(ssi_private->clk); > >+if (ret) > >+return ret; > > Will this work on PowerPC, where ssi_private->clk is always NULL? When ssi_private->clk is NULL, then ret = 0, so

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-11 Thread Timur Tabi
Shengjiu Wang wrote: + ret = clk_prepare_enable(ssi_private->clk); + if (ret) + return ret; Will this work on PowerPC, where ssi_private->clk is always NULL? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord..

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-11 Thread Shengjiu Wang
On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote: > On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote: > > Move the ipg clock enable and disable operation to startup and shutdown, > > that is only enable ipg clock when ssi is working. Keep clock is disabled > > when ssi is i

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-11 Thread Nicolin Chen
On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote: > Move the ipg clock enable and disable operation to startup and shutdown, > that is only enable ipg clock when ssi is working. Keep clock is disabled > when ssi is in idle. > otherwise, _fsl_ssi_set_dai_fmt function need to be called i