Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-15 Thread Rusty Russell
Cornelia Huck writes: > On Fri, 13 Feb 2015 13:22:09 +1030 > Rusty Russell wrote: > >> "Michael S. Tsirkin" writes: >> > On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: >> >> Jason Wang writes: >> >> > This patch enables the interrupt coalescing setting through ethtool. >> >> >>

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-15 Thread Rusty Russell
Pawel Moll writes: > On Fri, 2015-02-13 at 02:52 +, Rusty Russell wrote: >> "Michael S. Tsirkin" writes: >> > On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: >> >> Jason Wang writes: >> >> > This patch enables the interrupt coalescing setting through ethtool. >> >> >> >> The

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-13 Thread Cornelia Huck
On Fri, 13 Feb 2015 13:22:09 +1030 Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: > >> Jason Wang writes: > >> > This patch enables the interrupt coalescing setting through ethtool. > >> > >> The problem is that there's no

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-13 Thread Pawel Moll
On Fri, 2015-02-13 at 02:52 +, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: > >> Jason Wang writes: > >> > This patch enables the interrupt coalescing setting through ethtool. > >> > >> The problem is that there's noth

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-12 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: >> Jason Wang writes: >> > This patch enables the interrupt coalescing setting through ethtool. >> >> The problem is that there's nothing network specific about interrupt >> coalescing. I can see other

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-10 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: > Jason Wang writes: > > This patch enables the interrupt coalescing setting through ethtool. > > The problem is that there's nothing network specific about interrupt > coalescing. I can see other devices wanting exactly the same thi

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-10 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 06:59:30AM +0008, Jason Wang wrote: > > > On Tue, Feb 10, 2015 at 9:32 AM, Rusty Russell > wrote: > >Jason Wang writes: > >> This patch enables the interrupt coalescing setting through ethtool. > > > >The problem is that there's nothing network specific about interrupt >

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-09 Thread Jason Wang
On Tue, Feb 10, 2015 at 9:32 AM, Rusty Russell wrote: Jason Wang writes: This patch enables the interrupt coalescing setting through ethtool. The problem is that there's nothing network specific about interrupt coalescing. I can see other devices wanting exactly the same thing, which me

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-09 Thread Rusty Russell
Jason Wang writes: > This patch enables the interrupt coalescing setting through ethtool. The problem is that there's nothing network specific about interrupt coalescing. I can see other devices wanting exactly the same thing, which means we'd deprecate this in the next virtio standard. I think