Re: [PATCH RFC v3] mmc: sdhci-msm: Add support for MSM chipsets

2013-09-05 Thread Georgi Djakov
Hi Ivan, On 08/23/2013 10:34 AM, Ivan T. Ivanov wrote: Hi Georgi, On Tue, 2013-08-20 at 19:44 +0300, Georgi Djakov wrote: This platform driver adds the support of Secure Digital Host Controller Interface compliant controller in MSM chipsets. CC: Asutosh Das CC: Venkat Gopalakrishnan CC: Sah

Re: [PATCH RFC v3] mmc: sdhci-msm: Add support for MSM chipsets

2013-09-05 Thread Georgi Djakov
Hi Jaehoon, On 08/27/2013 11:55 AM, Jaehoon Chung wrote: Hi Georgi, I found the sdhci_msm_vreg_reset(). Why do you run enable->disable? +/* + * Reset vreg by ensuring it is off during probe. A call + * to enable vreg is needed to balance disable vreg + */ +static int sdhci_msm_vreg_reset(struc

Re: [PATCH RFC v3] mmc: sdhci-msm: Add support for MSM chipsets

2013-08-27 Thread Jaehoon Chung
Hi Georgi, I found the sdhci_msm_vreg_reset(). Why do you run enable->disable? +/* + * Reset vreg by ensuring it is off during probe. A call + * to enable vreg is needed to balance disable vreg + */ +static int sdhci_msm_vreg_reset(struct sdhci_msm_pltfm_data *pdata) I think that controller didn

Re: [PATCH RFC v3] mmc: sdhci-msm: Add support for MSM chipsets

2013-08-23 Thread Ivan T. Ivanov
Hi Georgi, On Tue, 2013-08-20 at 19:44 +0300, Georgi Djakov wrote: > This platform driver adds the support of Secure Digital Host > Controller Interface compliant controller in MSM chipsets. > > CC: Asutosh Das > CC: Venkat Gopalakrishnan > CC: Sahitya Tummala > CC: Subhash Jadavani > Signe