Re: [PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI

2013-09-09 Thread Josh Cartwright
Hey Mark- Thanks for the comments. On Mon, Sep 09, 2013 at 04:52:24PM +0100, Mark Brown wrote: > On Fri, Aug 23, 2013 at 11:06:25AM -0500, Josh Cartwright wrote: > > On Thu, Aug 22, 2013 at 04:10:54PM -0700, Greg Kroah-Hartman wrote: > > > On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright

Re: [PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI

2013-09-09 Thread Mark Brown
On Fri, Aug 23, 2013 at 11:06:25AM -0500, Josh Cartwright wrote: > On Thu, Aug 22, 2013 at 04:10:54PM -0700, Greg Kroah-Hartman wrote: > > On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote: > > > + "Example: Read 4 bytes starting at register address 0x1234 for SID 2\n" > > > + "\n" >

Re: [PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI

2013-08-23 Thread Josh Cartwright
On Thu, Aug 22, 2013 at 04:10:54PM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote: > > +static char dbgfs_help[] = > > + "SPMI Debug-FS support\n" > > + "\n" > > + "Hierarchy schema:\n" > > + "/sys/kernel/debug/spmi\n" > > + " /hel

Re: [PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI

2013-08-22 Thread Greg Kroah-Hartman
On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote: > +static char dbgfs_help[] = > + "SPMI Debug-FS support\n" > + "\n" > + "Hierarchy schema:\n" > + "/sys/kernel/debug/spmi\n" > + " /help-- Static help text\n" > + " /spmi-0