Re: [PATCH RFC 5/5] Add KSZ8795 SPI driver

2017-09-08 Thread Pavel Machek
Hi! > > Please format according to CodingStyle. (Not only this.) > > > > And this will be common for more drivers. Can it go to a header file > > and be included...? > > > > Sorry about the formatting. It seems my e-mail system needs to be checked > to make sure it does not auto-format the con

Re: [PATCH RFC 5/5] Add KSZ8795 SPI driver

2017-09-08 Thread Andrew Lunn
> Sorry about the formatting. It seems my e-mail system needs to be checked > to make sure it does not auto-format the contents again. I've never seen issues like this with git send-email. Please use it. Email problems generally happen with the client, not the backend. What client did you use to

RE: [PATCH RFC 5/5] Add KSZ8795 SPI driver

2017-09-08 Thread Tristram.Ha
.@gmail.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh - C21699 > Subject: Re: [PATCH RFC 5/5] Add KSZ8795 SPI driver > > Hi! > > > > +static int ksz_spi_read(struct ksz_device *dev, u32 reg, u8 *data, > > + unsigned int len) &

Re: [PATCH RFC 5/5] Add KSZ8795 SPI driver

2017-09-08 Thread Pavel Machek
Hi! > +static int ksz_spi_read(struct ksz_device *dev, u32 reg, u8 *data, > + unsigned int len) > +{ > + struct spi_device *spi = dev->priv; > + > + return ksz_spi_read_reg(spi, reg, data, len); } > + > +static int ksz_spi_read8(struct ksz_device *dev, u32 reg, u8 *val