Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-19 Thread Linus Walleij
On Thu, Oct 18, 2012 at 6:38 AM, Daniel Glöckner wrote: > On Mon, Oct 15, 2012 at 10:30:15PM +0200, Linus Walleij wrote: >> >> Another patch that is circulating concerns edge triggers and similar, >> and it appear that some parts of the GPIO sysfs is for example >> redefining and exporting IRQchip

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-17 Thread Daniel Glöckner
Hi, sorry for the late reply. I'm currently on vacation and it is no fun to use SSH with a 1s latency while Entel Chile injects RST/ACK packets. I'll read the remaining related mails that have accumulated in my inbox when I'm back home. On Mon, Oct 15, 2012 at 10:30:15PM +0200, Linus Walleij wrote

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-16 Thread Jean-Christophe PLAGNIOL-VILLARD
On 22:30 Mon 15 Oct , Linus Walleij wrote: > I really request Grant to comment on this...too. > > On Mon, Oct 15, 2012 at 8:19 PM, Greg Kroah-Hartman > wrote: > > On Mon, Oct 15, 2012 at 08:07:02PM +0200, Jean-Christophe PLAGNIOL-VILLARD > > wrote: > >> On 21:11 Fri 12 Oct , Roland Stigg

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-15 Thread Roland Stigge
On 15/10/12 22:30, Linus Walleij wrote: > I don't like it either, basically because the GPIO sysfs is not > entirely sound. > > Another patch that is circulating concerns edge triggers and similar, > and it appear that some parts of the GPIO sysfs is for example > redefining and exporting IRQchip

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-15 Thread Linus Walleij
I really request Grant to comment on this...too. On Mon, Oct 15, 2012 at 8:19 PM, Greg Kroah-Hartman wrote: > On Mon, Oct 15, 2012 at 08:07:02PM +0200, Jean-Christophe PLAGNIOL-VILLARD > wrote: >> On 21:11 Fri 12 Oct , Roland Stigge wrote: >> > This patch adds sysfs support to the block GPIO

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-15 Thread Greg Kroah-Hartman
On Mon, Oct 15, 2012 at 08:07:02PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 21:11 Fri 12 Oct , Roland Stigge wrote: > > This patch adds sysfs support to the block GPIO API. > > > > Signed-off-by: Roland Stigge > > > > --- > > Documentation/ABI/testing/sysfs-gpio |6 > > dri

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-15 Thread Roland Stigge
On 10/15/2012 08:07 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 21:11 Fri 12 Oct , Roland Stigge wrote: >> This patch adds sysfs support to the block GPIO API. >> >> Signed-off-by: Roland Stigge >> >> --- >> Documentation/ABI/testing/sysfs-gpio |6 >> drivers/gpio/gpiolib.c

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:11 Fri 12 Oct , Roland Stigge wrote: > This patch adds sysfs support to the block GPIO API. > > Signed-off-by: Roland Stigge > > --- > Documentation/ABI/testing/sysfs-gpio |6 > drivers/gpio/gpiolib.c | 226 > ++- > include/asm-gene

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-15 Thread Roland Stigge
On 10/15/2012 07:35 AM, Ryan Mallon wrote: >> --- linux-2.6.orig/Documentation/ABI/testing/sysfs-gpio >> +++ linux-2.6/Documentation/ABI/testing/sysfs-gpio >> @@ -24,4 +24,8 @@ Description: >> /base ... (r/o) same as N >> /label ... (r/o) descriptive, not necessarily unique >>

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-14 Thread Ryan Mallon
On 13/10/12 06:11, Roland Stigge wrote: > This patch adds sysfs support to the block GPIO API. > > Signed-off-by: Roland Stigge Hi Roland, Some comments below, ~Ryan > > --- > Documentation/ABI/testing/sysfs-gpio |6 > drivers/gpio/gpiolib.c | 226 >