Re: [PATCH RFC] Add FAT_IOCTL_GET_VOLUME_ID

2013-07-02 Thread OGAWA Hirofumi
bintian.w...@linaro.org writes: > From: Mike Lockwood > > This patch, originally from Android kernel, adds vfat ioctl command > FAT_IOCTL_GET_VOLUME_ID, with this command we can get the vfat volume ID using > following code: > > ioctl(fd, FAT_IOCTL_GET_VOLUME_ID, &volume_ID) > > This patch

Re: [PATCH RFC] Add FAT_IOCTL_GET_VOLUME_ID

2013-07-01 Thread OGAWA Hirofumi
bintian.w...@linaro.org writes: > From: Mike Lockwood > > Adds vfat ioctl command FAT_IOCTL_GET_VOLUME_ID, with this command > we can get the vfat volume ID using following code: > > ioctl(fd, FAT_IOCTL_GET_VOLUME_ID, &volume_ID) > > This patch is a modified version of the android kernel p

Re: [PATCH RFC] Add FAT_IOCTL_GET_VOLUME_ID

2013-07-01 Thread OGAWA Hirofumi
dmitry pervushin writes: > Honestly, I do not understand why getting volume id might be the > function of the mounted filesystem. I'd rather think about generic > function "filesystem id" of the block device. I see. Yes, I have same question too. > But if we decided to implement getting volume

Re: [PATCH RFC] Add FAT_IOCTL_GET_VOLUME_ID

2013-07-01 Thread OGAWA Hirofumi
dmitry pervushin writes: > Hello Bintian, > > The original idea discussed with John was to allow > FAT_IOCTL_GET_VOLUME_ID (broken or not) only on directory nodes, and > even on the root directory node. That's why it is should be *not* in > fat_generic_ioctl. The question would be, why do we hav

Re: [PATCH RFC] Add FAT_IOCTL_GET_VOLUME_ID

2013-06-30 Thread OGAWA Hirofumi
OGAWA Hirofumi writes: >> +case FAT_IOCTL_GET_VOLUME_ID: >> +id = fat_ioctl_volume_id(inode); >> +return copy_to_user((unsigned int *)arg, &id, sizeof(id)); > >> +case FAT_IOCTL_GET_VOLUME_ID: >> +id = fat_ioctl_volume_id(inode); >> +return

Re: [PATCH RFC] Add FAT_IOCTL_GET_VOLUME_ID

2013-06-30 Thread OGAWA Hirofumi
bintian.w...@linaro.org writes: > This patch, originally from Android kernel, adds vfat directory ioctl command > FAT_IOCTL_GET_VOLUME_ID, with this command we can get the vfat volume ID using > following code: > > ioctl(dirfd(dir), FAT_IOCTL_GET_VOLUME_ID, &volume_ID) > > This patch is a mo