Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-06 Thread Sudeep Dutt
On Fri, 2013-09-06 at 12:04 -0700, Greg Kroah-Hartman wrote: > On Fri, Sep 06, 2013 at 11:41:03AM -0700, Sudeep Dutt wrote: > > On Thu, 2013-09-05 at 22:01 -0700, Greg Kroah-Hartman wrote: > > > On Thu, Sep 05, 2013 at 04:41:55PM -0700, Sudeep Dutt wrote: > > > > +What: /sys/class/mic/mic(

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-06 Thread Greg Kroah-Hartman
On Fri, Sep 06, 2013 at 11:41:03AM -0700, Sudeep Dutt wrote: > On Thu, 2013-09-05 at 22:01 -0700, Greg Kroah-Hartman wrote: > > On Thu, Sep 05, 2013 at 04:41:55PM -0700, Sudeep Dutt wrote: > > > +What:/sys/class/mic/mic(x)/firmware > > > +Date:August 2013 > > > +KernelVersio

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-06 Thread Sudeep Dutt
On Thu, 2013-09-05 at 22:01 -0700, Greg Kroah-Hartman wrote: > On Thu, Sep 05, 2013 at 04:41:55PM -0700, Sudeep Dutt wrote: > > +What: /sys/class/mic/mic(x)/firmware > > +Date: August 2013 > > +KernelVersion: 3.11 > > +Contact: Sudeep Dutt > > +Description: > > +

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-06 Thread Greg Kroah-Hartman
On Fri, Sep 06, 2013 at 11:29:17AM -0700, Sudeep Dutt wrote: > On Thu, 2013-09-05 at 21:58 -0700, Greg Kroah-Hartman wrote: > > Again, very minor fixups for later (I can even do them...) > > > > > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, > > > mic_store_state); > > > > DEVICE_

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-06 Thread Sudeep Dutt
On Thu, 2013-09-05 at 21:58 -0700, Greg Kroah-Hartman wrote: > Again, very minor fixups for later (I can even do them...) > > > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, > > mic_store_state); > > DEVICE_ATTR_RW() please. > > Same for the other attributes you create in this pat

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-06 Thread Sudeep Dutt
On Thu, 2013-09-05 at 22:00 -0700, Greg Kroah-Hartman wrote: > On Thu, Sep 05, 2013 at 04:41:55PM -0700, Sudeep Dutt wrote: > > +What: /sys/class/mic/mic(x)/cmdline > > +Date: August 2013 > > +KernelVersion: 3.11 > > +Contact: Sudeep Dutt > > +Description: > > +

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-05 Thread Greg Kroah-Hartman
On Thu, Sep 05, 2013 at 04:41:55PM -0700, Sudeep Dutt wrote: > +What:/sys/class/mic/mic(x)/firmware > +Date:August 2013 > +KernelVersion: 3.11 > +Contact: Sudeep Dutt > +Description: > + When read, this sysfs entry provides the path name under

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-05 Thread Greg Kroah-Hartman
On Thu, Sep 05, 2013 at 04:41:55PM -0700, Sudeep Dutt wrote: > +What:/sys/class/mic/mic(x)/cmdline > +Date:August 2013 > +KernelVersion: 3.11 > +Contact: Sudeep Dutt > +Description: > + An Intel MIC device runs a Linux OS during its operation.

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-05 Thread Greg Kroah-Hartman
Again, very minor fixups for later (I can even do them...) > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); DEVICE_ATTR_RW() please. Same for the other attributes you create in this patch. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscr