Re: [PATCH RESEND] tracing: Fix overflow in get_free_elt()

On Wed, 7 Aug 2024 11:34:43 + Tze-nan Wu (吳澤南) wrote: > > > -idx = atomic_inc_return(&map->next_elt); > > > +idx = atomic_fetch_add_unless(&map->next_elt, 1, map->max_elts); > > > > I guess we need to add (with a comment): > > > > idx--; > > > Thanks for reviewing this! > > By referen

Re: [PATCH RESEND] tracing: Fix overflow in get_free_elt()

On Tue, 2024-08-06 at 15:40 -0400, Steven Rostedt wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Mon, 5 Aug 2024 13:59:22 +0800 > Tze-nan Wu wrote: > > > "tracing_map->next_elt" in get_free_elt() is at r

Re: [PATCH RESEND] tracing: Fix overflow in get_free_elt()

On Mon, 5 Aug 2024 13:59:22 +0800 Tze-nan Wu wrote: > "tracing_map->next_elt" in get_free_elt() is at risk of overflowing. > > Once it overflows, new elements can still be inserted into the tracing_map > even though the maximum number of elements (`max_elts`) has been reached. > Continuing to in