Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-19 Thread Mauro Carvalho Chehab
Em Mon, 18 Feb 2013 12:24:29 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 18 Feb 2013 14:52:51 +0100 > Borislav Petkov escreveu: > > > On Sun, Feb 17, 2013 at 07:44:04AM -0300, Mauro Carvalho Chehab wrote: > > > We could do it for the location. The space for label, however, depends on > > >

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-18 Thread Mauro Carvalho Chehab
Em Mon, 18 Feb 2013 14:52:51 +0100 Borislav Petkov escreveu: > On Sun, Feb 17, 2013 at 07:44:04AM -0300, Mauro Carvalho Chehab wrote: > > We could do it for the location. The space for label, however, depends on > > how many DIMMs are in the system, as multiple dimm's may be present, and > > the

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-18 Thread Borislav Petkov
On Sun, Feb 17, 2013 at 07:44:04AM -0300, Mauro Carvalho Chehab wrote: > We could do it for the location. The space for label, however, depends on > how many DIMMs are in the system, as multiple dimm's may be present, and > the core will point to all possible affected DIMMs. > > Ok, perhaps we cou

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-17 Thread Mauro Carvalho Chehab
Em Sat, 16 Feb 2013 17:57:48 +0100 Borislav Petkov escreveu: > On Fri, Feb 15, 2013 at 04:20:29PM -0200, Mauro Carvalho Chehab wrote: > > Yeah, pre-allocating a buffer is something that it was on my plans. It > > seems it is time to do it in a clean way. I prefer to keep this as a > > separate pa

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-16 Thread Borislav Petkov
On Fri, Feb 15, 2013 at 04:20:29PM -0200, Mauro Carvalho Chehab wrote: > Yeah, pre-allocating a buffer is something that it was on my plans. It > seems it is time to do it in a clean way. I prefer to keep this as a > separate patch from 07/13, as it has a different rationale, and mixing > with 07/1

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-15 Thread Mauro Carvalho Chehab
Em Fri, 15 Feb 2013 17:02:57 +0100 Borislav Petkov escreveu: > On Fri, Feb 15, 2013 at 01:49:29PM -0200, Mauro Carvalho Chehab wrote: > > Sure, but calling kmalloc while handling a memory error doesn't seem > > a very good idea, IMHO. So, better to either use an already allocated > > space (or th

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-15 Thread Borislav Petkov
On Fri, Feb 15, 2013 at 01:49:29PM -0200, Mauro Carvalho Chehab wrote: > Sure, but calling kmalloc while handling a memory error doesn't seem > a very good idea, IMHO. So, better to either use an already allocated > space (or the stack). Either that, or prealloc a buffer on EDAC initialization. Yo

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-15 Thread Mauro Carvalho Chehab
Em Fri, 15 Feb 2013 16:41:23 +0100 Borislav Petkov escreveu: > On Fri, Feb 15, 2013 at 01:25:30PM -0200, Mauro Carvalho Chehab wrote: > > Well, for sure using an structure will help to avoid missing a > > parameter or exchanging its order. The stack usage won't reduce, > > though, because the str

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-15 Thread Borislav Petkov
On Fri, Feb 15, 2013 at 01:25:30PM -0200, Mauro Carvalho Chehab wrote: > Well, for sure using an structure will help to avoid missing a > parameter or exchanging its order. The stack usage won't reduce, > though, because the structure will keep using the stack. If you allocate it on the stack of t

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-15 Thread Mauro Carvalho Chehab
Em Fri, 15 Feb 2013 15:13:30 +0100 Borislav Petkov escreveu: > On Fri, Feb 15, 2013 at 10:44:55AM -0200, Mauro Carvalho Chehab wrote: > > That allows APEI GHES driver to report errors directly, using > > the EDAC error report API. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > > driver

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-15 Thread Borislav Petkov
On Fri, Feb 15, 2013 at 10:44:55AM -0200, Mauro Carvalho Chehab wrote: > That allows APEI GHES driver to report errors directly, using > the EDAC error report API. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/edac/edac_core.h | 17 > drivers/edac/edac_mc.c | 109 > ++