Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Nick Terrell
> On Sep 17, 2020, at 6:47 PM, Chao Yu wrote: > > On 2020/9/18 3:34, Nick Terrell wrote: >>> On Sep 17, 2020, at 11:00 AM, Nick Terrell wrote: >>> >>> >>> On Sep 16, 2020, at 11:31 PM, Chao Yu wrote: Hi Nick, On 2020/9/17 2:39, Nick Terrell wrote: >> On Sep 1

Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Chao Yu
On 2020/9/18 10:56, Eric Biggers wrote: On Fri, Sep 18, 2020 at 09:47:32AM +0800, Chao Yu wrote: Ah, I got it. Step of enabling compressed inode is not correct, we should touch an empty file, and then use 'chattr +c' on that file to enable compression, otherwise the race condition could be comp

Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Eric Biggers
On Fri, Sep 18, 2020 at 09:47:32AM +0800, Chao Yu wrote: > Ah, I got it. > > Step of enabling compressed inode is not correct, we should touch an empty > file, and then use 'chattr +c' on that file to enable compression, otherwise > the race condition could be complicated to handle. So we need bel

Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Chao Yu
On 2020/9/18 3:34, Nick Terrell wrote: On Sep 17, 2020, at 11:00 AM, Nick Terrell wrote: On Sep 16, 2020, at 11:31 PM, Chao Yu wrote: Hi Nick, On 2020/9/17 2:39, Nick Terrell wrote: On Sep 15, 2020, at 11:31 PM, Chao Yu wrote: Hi Nick, remove not related mailing list. On 2020/9/16

Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Chao Yu
On 2020/9/18 2:00, Nick Terrell wrote: On Sep 16, 2020, at 11:31 PM, Chao Yu wrote: Hi Nick, On 2020/9/17 2:39, Nick Terrell wrote: On Sep 15, 2020, at 11:31 PM, Chao Yu wrote: Hi Nick, remove not related mailing list. On 2020/9/16 11:43, Nick Terrell wrote: From: Nick Terrell Move a

Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Nick Terrell
> On Sep 17, 2020, at 11:00 AM, Nick Terrell wrote: > > > >> On Sep 16, 2020, at 11:31 PM, Chao Yu wrote: >> >> Hi Nick, >> >> On 2020/9/17 2:39, Nick Terrell wrote: On Sep 15, 2020, at 11:31 PM, Chao Yu wrote: Hi Nick, remove not related mailing list. >>>

Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Nick Terrell
> On Sep 16, 2020, at 11:31 PM, Chao Yu wrote: > > Hi Nick, > > On 2020/9/17 2:39, Nick Terrell wrote: >>> On Sep 15, 2020, at 11:31 PM, Chao Yu wrote: >>> >>> Hi Nick, >>> >>> remove not related mailing list. >>> >>> On 2020/9/16 11:43, Nick Terrell wrote: From: Nick Terrell Mo

Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-16 Thread Chao Yu
Hi Nick, On 2020/9/17 2:39, Nick Terrell wrote: On Sep 15, 2020, at 11:31 PM, Chao Yu wrote: Hi Nick, remove not related mailing list. On 2020/9/16 11:43, Nick Terrell wrote: From: Nick Terrell Move away from the compatibility wrapper to the zstd-1.4.6 API. This code is more efficient b

Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-16 Thread Nick Terrell
> On Sep 15, 2020, at 11:31 PM, Chao Yu wrote: > > Hi Nick, > > remove not related mailing list. > > On 2020/9/16 11:43, Nick Terrell wrote: >> From: Nick Terrell >> Move away from the compatibility wrapper to the zstd-1.4.6 API. This >> code is more efficient because it uses the single-pass

Re: [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-15 Thread Chao Yu
Hi Nick, remove not related mailing list. On 2020/9/16 11:43, Nick Terrell wrote: From: Nick Terrell Move away from the compatibility wrapper to the zstd-1.4.6 API. This code is more efficient because it uses the single-pass API instead of the streaming API. The streaming API is not necessary