Re: [PATCH 6/8] x86/dump_pagetables: Add support 5-level paging

2017-03-28 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > On Tue, Mar 28, 2017 at 08:12:59AM +0200, Ingo Molnar wrote: > > > > * Kirill A. Shutemov wrote: > > > > > +#if PTRS_PER_P4D > 1 > > > + > > > +static void walk_p4d_level(struct seq_file *m, struct pg_state *st, > > > pgd_t addr, > > > +

Re: [PATCH 6/8] x86/dump_pagetables: Add support 5-level paging

2017-03-28 Thread Kirill A. Shutemov
On Tue, Mar 28, 2017 at 08:12:59AM +0200, Ingo Molnar wrote: > > * Kirill A. Shutemov wrote: > > > +#if PTRS_PER_P4D > 1 > > + > > +static void walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t > > addr, > > + unsigned long P) > > P

Re: [PATCH 6/8] x86/dump_pagetables: Add support 5-level paging

2017-03-27 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > +#if PTRS_PER_P4D > 1 > + > +static void walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t > addr, > + unsigned long P) Pretty ugly line break. Either don't break the line, or break it in a more logi