Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-09 Thread Kees Cook
On Wed, Oct 9, 2013 at 3:04 AM, HATAYAMA Daisuke wrote: > (2013/10/08 22:38), Dave Anderson wrote: >> >> >> >> - Original Message - >>> >>> (2013/10/07 22:21), Dave Anderson wrote: >>> - Original Message - > > (2013/10/03 22:47), Dave Anderson wrote: >>> >>> >> ---

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-09 Thread H. Peter Anvin
On 10/09/2013 03:04 AM, HATAYAMA Daisuke wrote: >>> >>> Sorry, I don't understand why relocation size cannot be calculated when >>> CONFIG_PHYSICALSTART > CONFIG_PHYSICAL_ALIGN. Could you explain that? >> >> I just meant that when CONFIG_PHYSICAL_START > CONFIG_PHYSICAL_ALIGN, >> the 32-bit x86 ker

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-09 Thread HATAYAMA Daisuke
(2013/10/08 22:38), Dave Anderson wrote: - Original Message - (2013/10/07 22:21), Dave Anderson wrote: - Original Message - (2013/10/03 22:47), Dave Anderson wrote: - Original Message - (2013/10/02 18:13), HATAYAMA Daisuke wrote: (2013/10/02 16:48), Kees Cook wr

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-08 Thread Dave Anderson
- Original Message - > (2013/10/07 22:21), Dave Anderson wrote: > > > - Original Message - > >> (2013/10/03 22:47), Dave Anderson wrote: > > >>> - Original Message - > (2013/10/02 18:13), HATAYAMA Daisuke wrote: > > (2013/10/02 16:48), Kees Cook wrote: > > >> >

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-08 Thread HATAYAMA Daisuke
(2013/10/07 22:21), Dave Anderson wrote: - Original Message - (2013/10/03 22:47), Dave Anderson wrote: - Original Message - (2013/10/02 18:13), HATAYAMA Daisuke wrote: (2013/10/02 16:48), Kees Cook wrote: Thanks for detailed explanation. So, there's already a feature in

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-07 Thread Dave Anderson
- Original Message - > (2013/10/03 22:47), Dave Anderson wrote: > > > > > > - Original Message - > >> (2013/10/02 18:13), HATAYAMA Daisuke wrote: > >>> (2013/10/02 16:48), Kees Cook wrote: > >> > >> + > >> + return 0; > >> +} > >> + > >> +/* > >>

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-06 Thread HATAYAMA Daisuke
(2013/10/03 22:47), Dave Anderson wrote: - Original Message - (2013/10/02 18:13), HATAYAMA Daisuke wrote: (2013/10/02 16:48), Kees Cook wrote: + + return 0; +} + +/* * Determine if we were loaded by an EFI loader. If so, then we have also been * passed the efi memma

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-03 Thread Dave Anderson
- Original Message - > (2013/10/02 18:13), HATAYAMA Daisuke wrote: > > (2013/10/02 16:48), Kees Cook wrote: > > + > + return 0; > +} > + > +/* > * Determine if we were loaded by an EFI loader. If so, then we have > also been > * passe

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-02 Thread HATAYAMA Daisuke
(2013/10/02 18:13), HATAYAMA Daisuke wrote: (2013/10/02 16:48), Kees Cook wrote: + + return 0; +} + +/* * Determine if we were loaded by an EFI loader. If so, then we have also been * passed the efi memmap, systab, etc., so we should use these data structures * for initializ

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-02 Thread HATAYAMA Daisuke
(2013/10/02 16:48), Kees Cook wrote: On Tue, Oct 1, 2013 at 5:38 PM, HATAYAMA Daisuke wrote: (2013/10/02 4:37), Kees Cook wrote: When the system panics, include the kernel offset in the report to assist in debugging. Signed-off-by: Kees Cook --- arch/x86/kernel/setup.c | 26

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-02 Thread Kees Cook
On Tue, Oct 1, 2013 at 6:06 PM, HATAYAMA Daisuke wrote: > (2013/10/02 9:38), HATAYAMA Daisuke wrote: >> (2013/10/02 4:37), Kees Cook wrote: > >>> @@ -1242,3 +1256,15 @@ void __init i386_reserve_resources(void) >>>} >>> >>>#endif /* CONFIG_X86_32 */ >>> + >>> +static struct notifier_block

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-02 Thread Kees Cook
On Tue, Oct 1, 2013 at 5:38 PM, HATAYAMA Daisuke wrote: > (2013/10/02 4:37), Kees Cook wrote: >> When the system panics, include the kernel offset in the report to assist >> in debugging. >> >> Signed-off-by: Kees Cook >> --- >> arch/x86/kernel/setup.c | 26 ++ >> 1 f

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-01 Thread HATAYAMA Daisuke
(2013/10/02 9:38), HATAYAMA Daisuke wrote: > (2013/10/02 4:37), Kees Cook wrote: >> @@ -1242,3 +1256,15 @@ void __init i386_reserve_resources(void) >>} >> >>#endif /* CONFIG_X86_32 */ >> + >> +static struct notifier_block kernel_offset_notifier = { >> +.notifier_call = dump_kernel_

Re: [PATCH 6/7] x86, kaslr: report kernel offset on panic

2013-10-01 Thread HATAYAMA Daisuke
(2013/10/02 4:37), Kees Cook wrote: > When the system panics, include the kernel offset in the report to assist > in debugging. > > Signed-off-by: Kees Cook > --- > arch/x86/kernel/setup.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/x86/kernel/s