Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-25 Thread Dmitri Vorobiev
Adrian Bunk пишет: > On Thu, Jan 24, 2008 at 11:22:21PM +, Tigran Aivazian wrote: >> On Fri, 25 Jan 2008, Dmitri Vorobiev wrote: >> >>> Heikki Orsila пишет: > +extern void dump_imap(const char *, struct super_block *); > + Functions should not be externed, remove extern keyword. >>

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-25 Thread Adrian Bunk
On Thu, Jan 24, 2008 at 11:22:21PM +, Tigran Aivazian wrote: > On Fri, 25 Jan 2008, Dmitri Vorobiev wrote: > >> Heikki Orsila пишет: +extern void dump_imap(const char *, struct super_block *); + >>> >>> Functions should not be externed, remove extern keyword. >>> >> >> Care to explain

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Kyle Moffett
On Jan 24, 2008, at 18:13, Dmitri Vorobiev wrote: Heikki Orsila пишет: On Fri, Jan 25, 2008 at 01:32:04AM +0300, Dmitri Vorobiev wrote: +/* inode.c */ +extern void dump_imap(const char *, struct super_block *); + Functions should not be externed, remove extern keyword. Care to explain why?

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Dmitri Vorobiev
Heikki Orsila пишет: > On Fri, Jan 25, 2008 at 02:13:00AM +0300, Dmitri Vorobiev wrote: >> Care to explain why? > > Because functions are always external objects in C. I just verified that > from K&R. > Yes, I know that :) The reasons behind me using this keyword were: 1) to keep the code symm

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Heikki Orsila
On Fri, Jan 25, 2008 at 02:13:00AM +0300, Dmitri Vorobiev wrote: > Care to explain why? Because functions are always external objects in C. I just verified that from K&R. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://w

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Dmitri Vorobiev
Tigran Aivazian пишет: > On Fri, 25 Jan 2008, Dmitri Vorobiev wrote: > >> Heikki Orsila пишет: +extern void dump_imap(const char *, struct super_block *); + >>> >>> Functions should not be externed, remove extern keyword. >>> >> >> Care to explain why? > > because dump_imap() is just a

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Tigran Aivazian
On Fri, 25 Jan 2008, Dmitri Vorobiev wrote: Heikki Orsila пишет: +extern void dump_imap(const char *, struct super_block *); + Functions should not be externed, remove extern keyword. Care to explain why? because dump_imap() is just a BFS' internal helper (for debugging purposes only bt

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Tigran Aivazian
On Fri, 25 Jan 2008, Heikki Orsila wrote: On Fri, Jan 25, 2008 at 01:32:04AM +0300, Dmitri Vorobiev wrote: diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h index 090b96e..ecc74bb 100644 --- a/fs/bfs/bfs.h +++ b/fs/bfs/bfs.h ... +/* inode.c */ +extern void dump_imap(const char *, struct super_block *);

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Tigran Aivazian
Ooops, I didn't look at the _name_ of the function, i.e. it being dump_imap(), an internal helper --- of course it shouldn't be extern'd you are right :) On Thu, 24 Jan 2008, Tigran Aivazian wrote: On Fri, 25 Jan 2008, Heikki Orsila wrote: On Fri, Jan 25, 2008 at 01:32:04AM +0300, Dmitri Vor

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Dmitri Vorobiev
Heikki Orsila пишет: > On Fri, Jan 25, 2008 at 01:32:04AM +0300, Dmitri Vorobiev wrote: >> diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h >> index 090b96e..ecc74bb 100644 >> --- a/fs/bfs/bfs.h >> +++ b/fs/bfs/bfs.h > ... >> +/* inode.c */ >> +extern void dump_imap(const char *, struct super_block *); >>

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Heikki Orsila
On Fri, Jan 25, 2008 at 01:32:04AM +0300, Dmitri Vorobiev wrote: > diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h > index 090b96e..ecc74bb 100644 > --- a/fs/bfs/bfs.h > +++ b/fs/bfs/bfs.h ... > +/* inode.c */ > +extern void dump_imap(const char *, struct super_block *); > + Functions should not be exter