Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-05-16 Thread Linus Walleij
On Thu, May 16, 2013 at 11:12 AM, James Hogan wrote: > Hi Linus, > On 15/05/13 20:07, Linus Walleij wrote: >> On Tue, May 14, 2013 at 2:22 PM, James Hogan wrote: >> >>> I think that's the other way around, i.e. that's talking about mapping >>> several pingroups to the same function. The next para

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-05-16 Thread James Hogan
Hi Linus, On 15/05/13 20:07, Linus Walleij wrote: > On Tue, May 14, 2013 at 2:22 PM, James Hogan wrote: > >> I think that's the other way around, i.e. that's talking about mapping >> several pingroups to the same function. The next paragraph is closer to >> the problem: >> >> Documentation/pinct

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-05-15 Thread Linus Walleij
On Tue, May 14, 2013 at 2:22 PM, James Hogan wrote: > I think that's the other way around, i.e. that's talking about mapping > several pingroups to the same function. The next paragraph is closer to > the problem: > > Documentation/pinctrl.txt >> - PINS for a certain FUNCTION using a certain PIN

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-05-14 Thread James Hogan
On 14/05/13 12:52, Linus Walleij wrote: > On Fri, May 3, 2013 at 5:06 PM, James Hogan wrote: >> [me] >>> Thus this part of the problem (poking that "select" bit) >>> should be handled by the pinmux part of the driver. >>> >>> The pinconf part does not need to know about it. >> >> Okay, so how woul

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-05-14 Thread Linus Walleij
On Fri, May 3, 2013 at 5:06 PM, James Hogan wrote: > [me] >> Thus this part of the problem (poking that "select" bit) >> should be handled by the pinmux part of the driver. >> >> The pinconf part does not need to know about it. > > Okay, so how would you recommend handling the case of a pin in a m

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-05-03 Thread James Hogan
Hi Linus, On 03/05/13 14:03, Linus Walleij wrote: > On Fri, May 3, 2013 at 2:23 PM, James Hogan wrote: >> [Me] >>> If what you need is to set the pin into "GPIO mode" to drive it >>> to some default state then from pinconf-generic.h you should use >>> one of the existing defines like PIN_CONFIG_O

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-05-03 Thread Linus Walleij
On Fri, May 3, 2013 at 2:23 PM, James Hogan wrote: > [Me] >> If what you need is to set the pin into "GPIO mode" to drive it >> to some default state then from pinconf-generic.h you should use >> one of the existing defines like PIN_CONFIG_OUTPUT >> to actively drive it to high or low as default,

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-05-03 Thread James Hogan
Hi Linus, On 03/05/13 10:13, Linus Walleij wrote: > On Fri, Apr 26, 2013 at 1:54 PM, James Hogan wrote: >> On 25/04/13 23:39, Linus Walleij wrote: >>> On Tue, Apr 23, 2013 at 4:33 PM, James Hogan wrote: +static const struct cfg_param { + const char *property; + enum tz

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-05-03 Thread Linus Walleij
On Fri, Apr 26, 2013 at 1:54 PM, James Hogan wrote: > On 25/04/13 23:39, Linus Walleij wrote: >> On Tue, Apr 23, 2013 at 4:33 PM, James Hogan wrote: >> (...) >>> +/* Pin names */ >>> + >>> +static const struct pinctrl_pin_desc tz1090_pins[] = { >>> + /* Normal GPIOs */ >>> + PINCTRL_P

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-04-26 Thread James Hogan
Hi Linus, On 25/04/13 23:39, Linus Walleij wrote: > On Tue, Apr 23, 2013 at 4:33 PM, James Hogan wrote: > >> Add a pin control driver for the main pins on the TZ1090 SoC. This >> doesn't include the low-power pins as they're controlled separately via >> the Powerdown Controller (PDC) registers.

Re: [PATCH 5/8] pinctrl-tz1090: add TZ1090 pinctrl driver

2013-04-25 Thread Linus Walleij
On Tue, Apr 23, 2013 at 4:33 PM, James Hogan wrote: > Add a pin control driver for the main pins on the TZ1090 SoC. This > doesn't include the low-power pins as they're controlled separately via > the Powerdown Controller (PDC) registers. > > Signed-off-by: James Hogan > Cc: Grant Likely > Cc: