* Oleg Nesterov [2012-10-06 20:59:49]:
> On 10/06, Srikar Dronamraju wrote:
> >
> > Yeah prepare_uprobe() looks good for me.
> >
> > Acked-by: Srikar Dronamraju
>
> OK, renamed.
>
> The next patches updated accordinly, I hope I can keep your acks.
Yes, please keep my acks as I understand that
On 10/06, Srikar Dronamraju wrote:
>
> Yeah prepare_uprobe() looks good for me.
>
> Acked-by: Srikar Dronamraju
OK, renamed.
The next patches updated accordinly, I hope I can keep your acks.
--
[PATCH] uprobes: Introduc
> > uprobe_copy_insn.
>
> Yes ;) plus it is not only "copy", it does _analyze
>
> > Not sure test_and_copy_insn() is a good alternative.
>
> perhaps prepare_uprobe()... But I agree with any naming, just tell me
> what you prefer and I'll update the patch again.
Yeah prepare_uprobe() looks good
On 10/06, Srikar Dronamraju wrote:
>
> * Oleg Nesterov [2012-09-30 21:42:17]:
>
> > +static int uprobe_copy_insn(struct uprobe *uprobe, struct file *file,
> > + struct mm_struct *mm, unsigned long vaddr)
> > +{
> > + int ret = 0;
> > +
> > + if (uprobe->flags & UPROBE
* Oleg Nesterov [2012-09-30 21:42:17]:
> Preparation. Extract the copy_insn/arch_uprobe_analyze_insn code
> from install_breakpoint() into the new helper, uprobe_copy_insn().
>
> And move uprobe->flags defines from uprobes.h to uprobes.c, nobody
> else can use them anyway.
>
> Signed-off-by: Ol
5 matches
Mail list logo
