Re: [PATCH 5/7] blk-mq: initialize request on allocation

2014-04-17 Thread Ming Lei
On Thu, Apr 17, 2014 at 10:57 PM, Christoph Hellwig wrote: > On Thu, Apr 17, 2014 at 10:54:23PM +0800, Ming Lei wrote: >> On Mon, Apr 14, 2014 at 4:30 PM, Christoph Hellwig wrote: >> > If we want to share tag and request allocation between queues we cannot >> > initialize the request at init/free

Re: [PATCH 5/7] blk-mq: initialize request on allocation

2014-04-17 Thread Christoph Hellwig
On Thu, Apr 17, 2014 at 10:54:23PM +0800, Ming Lei wrote: > On Mon, Apr 14, 2014 at 4:30 PM, Christoph Hellwig wrote: > > If we want to share tag and request allocation between queues we cannot > > initialize the request at init/free time, but need to initialize it > > at allocation time as it mig

Re: [PATCH 5/7] blk-mq: initialize request on allocation

2014-04-17 Thread Ming Lei
On Mon, Apr 14, 2014 at 4:30 PM, Christoph Hellwig wrote: > If we want to share tag and request allocation between queues we cannot > initialize the request at init/free time, but need to initialize it > at allocation time as it might get used for different queues over its > lifetime. Could you e