Re: [PATCH 5/6] KVM: s390: wire up seb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 12:33 PM, David Hildenbrand wrote: > >> #define ECB_GS 0x40 >> #define ECB_TE 0x10 >> #define ECB_SRSI0x04 >> diff --git a/arch/s390/include/uapi/asm/kvm.h >> b/arch/s390/include/uapi/asm/kvm.h >> index 38535a57..20b9e9f 100644 >> --- a/arch/s390/i

Re: [PATCH 5/6] KVM: s390: wire up seb feature

2018-01-17 Thread David Hildenbrand
> #define ECB_GS 0x40 > #define ECB_TE 0x10 > #define ECB_SRSI 0x04 > diff --git a/arch/s390/include/uapi/asm/kvm.h > b/arch/s390/include/uapi/asm/kvm.h > index 38535a57..20b9e9f 100644 > --- a/arch/s390/include/uapi/asm/kvm.h > +++ b/arch/s390/include/uapi/asm/

Re: [PATCH 5/6] KVM: s390: wire up seb feature

2018-01-17 Thread Paolo Bonzini
On 17/01/2018 12:29, Christian Borntraeger wrote: >> The problem is not that I announce the facility, I in fact announce that the >> programmatic interface is available (the sebc sync reg and the usage of that >> field). >> (So the CAP is part of this patch to have both in lockstep) >> A non-exist

Re: [PATCH 5/6] KVM: s390: wire up seb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 12:28 PM, Christian Borntraeger wrote: > > > On 01/17/2018 12:22 PM, Paolo Bonzini wrote: >>> while this is kvm code, my current plan is to submit the "final" >>> version after review and probably some fixes/renames via Martin >>> together with the other patches. Are you ok with

Re: [PATCH 5/6] KVM: s390: wire up seb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 12:22 PM, Paolo Bonzini wrote: >> while this is kvm code, my current plan is to submit the "final" >> version after review and probably some fixes/renames via Martin >> together with the other patches. Are you ok with that? Right now it >> seems that the CAP number is still fine. >

Re: [PATCH 5/6] KVM: s390: wire up seb feature

2018-01-17 Thread Paolo Bonzini
> while this is kvm code, my current plan is to submit the "final" > version after review and probably some fixes/renames via Martin > together with the other patches. Are you ok with that? Right now it > seems that the CAP number is still fine. Sure, though there will be a capability introduced b

Re: [PATCH 5/6] KVM: s390: wire up seb feature

2018-01-17 Thread Christian Borntraeger
Paolo, while this is kvm code, my current plan is to submit the "final" version after review and probably some fixes/renames via Martin together with the other patches. Are you ok with that? Right now it seems that the CAP number is still fine. Christian On 01/17/2018 10:48 AM, Martin Schwidefs