Re: [PATCH 5/5] x86: TLS cleanup

2007-11-21 Thread Roland McGrath
> I had a bit of trouble verifying correctness here because of much > brownian motion. Any possibility of a pure movement / fixup separation > to make it easier on the eyes? Yeah, sorry about that. It was late and the whole TLS thing was a sudden afterthought while I was in the middle of doing s

Re: [PATCH 5/5] x86: TLS cleanup

2007-11-21 Thread Zachary Amsden
On Wed, 2007-11-21 at 02:25 -0800, Roland McGrath wrote: > This consolidates the four different places that implemented the same > encoding magic for the GDT-slot 32-bit TLS support. The old tls32.c is > renamed and only slightly modified to be the shared implementation guts. > -#define GET_BASE(

Re: [PATCH 5/5] x86: TLS cleanup

2007-11-21 Thread Thomas Gleixner
On Wed, 21 Nov 2007, Roland McGrath wrote: > > This consolidates the four different places that implemented the same > encoding magic for the GDT-slot 32-bit TLS support. The old tls32.c is > renamed and only slightly modified to be the shared implementation guts. Cool patchset. One minor nit