Re: [PATCH 5/5] drm/vc4: fix fb references in async update

2019-03-11 Thread Boris Brezillon
+Eric (the VC4 driver maintainer) Hello Helen, On Mon, 4 Mar 2019 11:49:09 -0300 Helen Koike wrote: > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Calling drm_atomic_set_fb_for_plane() (which gets a reference of the

Re: [PATCH 5/5] drm/vc4: fix fb references in async update

2019-03-05 Thread Helen Koike
On 3/4/19 11:49 AM, Helen Koike wrote: > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Calling drm_atomic_set_fb_for_plane() (which gets a reference of the new > fb and put the old fb) is not required, as it's taken ca