Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2025-04-10 Thread Myrsky Lintu
Thank you. I will try to bring this up with QEMU developers then. On 2025-04-10 05:12:01, Yan Zhao wrote: > Hi, > > AFAIK, the commit c9c1e20b4c7d ("KVM: x86: Introduce Intel specific quirk > KVM_X86_QUIRK_IGNORE_GUEST_PAT") which re-allows honoring guest PAT on Intel's > platforms has been in kv

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2025-04-09 Thread Yan Zhao
Hi, AFAIK, the commit c9c1e20b4c7d ("KVM: x86: Introduce Intel specific quirk KVM_X86_QUIRK_IGNORE_GUEST_PAT") which re-allows honoring guest PAT on Intel's platforms has been in kvm/queue now. However, as the quirk is enabled by default, userspace(like QEMU) needs to turn it off by code like "kv

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2025-04-09 Thread Myrsky Lintu
Hello, I am completely new to and uninformed about kernel development. I was pointed here from Mesa documentation for Venus (Vulkan encapsulation for KVM/QEMU): https://docs.mesa3d.org/drivers/venus.html Based on my limited understanding of what has happened here, this patch series was partial

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-10-07 Thread Linux regression tracking (Thorsten Leemhuis)
On 07.10.24 15:38, Vitaly Kuznetsov wrote: > "Linux regression tracking (Thorsten Leemhuis)" > writes: > >> On 30.08.24 11:35, Vitaly Kuznetsov wrote: >>> Sean Christopherson writes: >>> Unconditionally honor guest PAT on CPUs that support self-snoop, as Intel has confirmed that CPUs t

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-10-07 Thread Vitaly Kuznetsov
"Linux regression tracking (Thorsten Leemhuis)" writes: > On 30.08.24 11:35, Vitaly Kuznetsov wrote: >> Sean Christopherson writes: >> >>> Unconditionally honor guest PAT on CPUs that support self-snoop, as >>> Intel has confirmed that CPUs that support self-snoop always snoop caches >>> and st

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-10-07 Thread Linux regression tracking (Thorsten Leemhuis)
On 30.08.24 11:35, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > >> Unconditionally honor guest PAT on CPUs that support self-snoop, as >> Intel has confirmed that CPUs that support self-snoop always snoop caches >> and store buffers. I.e. CPUs with self-snoop maintain cache coherency

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-09 Thread Yan Zhao
On Mon, Sep 09, 2024 at 03:24:40PM +0200, Paolo Bonzini wrote: > While this is a fix for future kernels, it doesn't change the result for VMs > already in existence. Though this is the truth, I have concerns that there may be other guest drivers with improper PAT configurations that were previously

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-09 Thread Sean Christopherson
On Mon, Sep 09, 2024, Paolo Bonzini wrote: > On 9/9/24 07:30, Yan Zhao wrote: > > On Thu, Sep 05, 2024 at 05:43:17PM +0800, Yan Zhao wrote: > > > On Wed, Sep 04, 2024 at 05:41:06PM -0700, Sean Christopherson wrote: > > > > On Wed, Sep 04, 2024, Yan Zhao wrote: > > > > > On Wed, Sep 04, 2024 at 10:2

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-09 Thread Paolo Bonzini
On 9/9/24 07:30, Yan Zhao wrote: On Thu, Sep 05, 2024 at 05:43:17PM +0800, Yan Zhao wrote: On Wed, Sep 04, 2024 at 05:41:06PM -0700, Sean Christopherson wrote: On Wed, Sep 04, 2024, Yan Zhao wrote: On Wed, Sep 04, 2024 at 10:28:02AM +0800, Yan Zhao wrote: On Tue, Sep 03, 2024 at 06:20:27PM +0

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-08 Thread Yan Zhao
On Thu, Sep 05, 2024 at 05:43:17PM +0800, Yan Zhao wrote: > On Wed, Sep 04, 2024 at 05:41:06PM -0700, Sean Christopherson wrote: > > On Wed, Sep 04, 2024, Yan Zhao wrote: > > > On Wed, Sep 04, 2024 at 10:28:02AM +0800, Yan Zhao wrote: > > > > On Tue, Sep 03, 2024 at 06:20:27PM +0200, Vitaly Kuznets

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-05 Thread Yan Zhao
On Wed, Sep 04, 2024 at 05:41:06PM -0700, Sean Christopherson wrote: > On Wed, Sep 04, 2024, Yan Zhao wrote: > > On Wed, Sep 04, 2024 at 10:28:02AM +0800, Yan Zhao wrote: > > > On Tue, Sep 03, 2024 at 06:20:27PM +0200, Vitaly Kuznetsov wrote: > > > > Sean Christopherson writes: > > > > > > > > >

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-04 Thread Sean Christopherson
On Wed, Sep 04, 2024, Yan Zhao wrote: > On Wed, Sep 04, 2024 at 10:28:02AM +0800, Yan Zhao wrote: > > On Tue, Sep 03, 2024 at 06:20:27PM +0200, Vitaly Kuznetsov wrote: > > > Sean Christopherson writes: > > > > > > > On Mon, Sep 02, 2024, Vitaly Kuznetsov wrote: > > > >> FWIW, I use QEMU-9.0 from

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-04 Thread Yan Zhao
On Wed, Sep 04, 2024 at 10:28:02AM +0800, Yan Zhao wrote: > On Tue, Sep 03, 2024 at 06:20:27PM +0200, Vitaly Kuznetsov wrote: > > Sean Christopherson writes: > > > > > On Mon, Sep 02, 2024, Vitaly Kuznetsov wrote: > > >> FWIW, I use QEMU-9.0 from the same C10S (qemu-kvm-9.0.0-7.el10.x86_64) > > >

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-04 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Sean Christopherson writes: > >> On Mon, Sep 02, 2024, Vitaly Kuznetsov wrote: >>> FWIW, I use QEMU-9.0 from the same C10S (qemu-kvm-9.0.0-7.el10.x86_64) >>> but I don't think it matters in this case. My CPU is "Intel(R) Xeon(R) >>> Silver 4410Y". >> >> Has this been r

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-03 Thread Yan Zhao
On Tue, Sep 03, 2024 at 06:20:27PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > On Mon, Sep 02, 2024, Vitaly Kuznetsov wrote: > >> FWIW, I use QEMU-9.0 from the same C10S (qemu-kvm-9.0.0-7.el10.x86_64) > >> but I don't think it matters in this case. My CPU is "Intel(R) Xeon(

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-03 Thread Vitaly Kuznetsov
Sean Christopherson writes: > On Mon, Sep 02, 2024, Vitaly Kuznetsov wrote: >> FWIW, I use QEMU-9.0 from the same C10S (qemu-kvm-9.0.0-7.el10.x86_64) >> but I don't think it matters in this case. My CPU is "Intel(R) Xeon(R) >> Silver 4410Y". > > Has this been reproduced on any other hardware besi

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-03 Thread Sean Christopherson
On Mon, Sep 02, 2024, Vitaly Kuznetsov wrote: > FWIW, I use QEMU-9.0 from the same C10S (qemu-kvm-9.0.0-7.el10.x86_64) > but I don't think it matters in this case. My CPU is "Intel(R) Xeon(R) > Silver 4410Y". Has this been reproduced on any other hardware besides SPR? I.e. did we stumble on anoth

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-02 Thread Vitaly Kuznetsov
Yan Zhao writes: > On Fri, Aug 30, 2024 at 03:47:11PM +0200, Vitaly Kuznetsov wrote: >> Gerd Hoffmann writes: >> >> >> Necroposting! >> >> >> >> Turns out that this change broke "bochs-display" driver in QEMU even >> >> when the guest is modern (don't ask me 'who the hell uses bochs for >> >>

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-02 Thread Gerd Hoffmann
> > > Yes? :-) As Gerd described, video memory is "mapped into userspace so > > > the wayland / X11 display server can software-render into the buffer" > > > and it seems that wayland gets something unexpected in this memory and > > > crashes. > > > > Also, I don't know if it helps or not, but ou

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-01 Thread Yan Zhao
On Fri, Aug 30, 2024 at 03:47:11PM +0200, Vitaly Kuznetsov wrote: > Gerd Hoffmann writes: > > >> Necroposting! > >> > >> Turns out that this change broke "bochs-display" driver in QEMU even > >> when the guest is modern (don't ask me 'who the hell uses bochs for > >> modern guests', it was basic