Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-06-07 Thread Linus Walleij
On Thu, May 31, 2018 at 1:21 PM, Sebastian Gottschall wrote: > this patch creates a regression for me. on ipq8064 the systems gpios now > start somewhere in the sky (...) > this broke my userspace gpio handling. i can override this, but still it > doesnt look correct since there is a hole at the

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-06-01 Thread Timur Tabi
On 5/31/18 11:57 AM, Bjorn Andersson wrote: (Although that would probably break if Timur's customers move their user space to the new platform as "the first instance" isn't deterministic). Users of platforms that have multiple TLMMs should be required to use gpiolib instead of sysfs. I've alr

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-06-01 Thread Sebastian Gottschall
Am 31.05.2018 um 18:57 schrieb Bjorn Andersson: On Thu 31 May 04:45 PDT 2018, Greg Kroah-Hartman wrote: On Thu, May 31, 2018 at 01:21:56PM +0200, Sebastian Gottschall wrote: Am 28.05.2018 um 12:05 schrieb Greg Kroah-Hartman: 4.16-stable review patch. If anyone has any objections, please l

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-05-31 Thread Bjorn Andersson
On Thu 31 May 04:45 PDT 2018, Greg Kroah-Hartman wrote: > On Thu, May 31, 2018 at 01:21:56PM +0200, Sebastian Gottschall wrote: > > Am 28.05.2018 um 12:05 schrieb Greg Kroah-Hartman: > > > 4.16-stable review patch. If anyone has any objections, please let me > > > know. > > > > > >

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-05-31 Thread Greg Kroah-Hartman
On Thu, May 31, 2018 at 10:09:50AM -0500, Timur Tabi wrote: > On 5/31/18 7:12 AM, Greg Kroah-Hartman wrote: > > Why is it somehow ok for "future" kernels? You can't break the api in > > the future for no reason. > > > > So this needs to be the same everywhere. If it is broken in 4.17-rc, it > >

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-05-31 Thread Timur Tabi
On 5/31/18 7:12 AM, Greg Kroah-Hartman wrote: Why is it somehow ok for "future" kernels? You can't break the api in the future for no reason. So this needs to be the same everywhere. If it is broken in 4.17-rc, it needs to be reverted. This was discussed here: https://www.spinics.net/lists/

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-05-31 Thread Sebastian Gottschall
Am 31.05.2018 um 14:12 schrieb Greg Kroah-Hartman: On Thu, May 31, 2018 at 06:55:55AM -0500, Timur Tabi wrote: On 5/31/18 6:53 AM, Sebastian Gottschall wrote: i checked initially 4.9 with latest patches and 4.14 and reverted this line to get back to the old behaviour but a which view in the

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-05-31 Thread Greg Kroah-Hartman
On Thu, May 31, 2018 at 06:55:55AM -0500, Timur Tabi wrote: > On 5/31/18 6:53 AM, Sebastian Gottschall wrote: > > > > > i checked initially 4.9 with latest patches and 4.14 and reverted this > > line to get back to the old behaviour but a which view in the current > > 4.17 tree shows > > that the

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-05-31 Thread Timur Tabi
On 5/31/18 6:53 AM, Sebastian Gottschall wrote: i checked initially 4.9 with latest patches and 4.14 and reverted this line to get back to the old behaviour but a which view in the current 4.17 tree shows that the same patch has been included in 4.17. it was introduced in the kernel mainline 

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-05-31 Thread Sebastian Gottschall
Am 31.05.2018 um 13:45 schrieb Greg Kroah-Hartman: On Thu, May 31, 2018 at 01:21:56PM +0200, Sebastian Gottschall wrote: Am 28.05.2018 um 12:05 schrieb Greg Kroah-Hartman: 4.16-stable review patch. If anyone has any objections, please let me know. -- From: Bjorn Andersson

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-05-31 Thread Greg Kroah-Hartman
On Thu, May 31, 2018 at 01:21:56PM +0200, Sebastian Gottschall wrote: > Am 28.05.2018 um 12:05 schrieb Greg Kroah-Hartman: > > 4.16-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Bjorn Andersson > > > > [ Upstream commit a7aa75a2

Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

2018-05-31 Thread Sebastian Gottschall
Am 28.05.2018 um 12:05 schrieb Greg Kroah-Hartman: 4.16-stable review patch. If anyone has any objections, please let me know. -- From: Bjorn Andersson [ Upstream commit a7aa75a2a7dba32594291a71c3704000a2fd7089 ] The base of the TLMM gpiochip should not be statically defined