Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"

2017-09-13 Thread Luis R. Rodriguez
On Wed, Sep 13, 2017 at 12:30:44PM -0700, Linus Torvalds wrote: > Yes, the movement of the locking might need to be reverted too - but > only if it actually shows problems. This speeds up the cleanup of that crap UMH code so I'm happy to wait to hear if just the move the UMH lock it creates an iss

Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"

2017-09-13 Thread Linus Torvalds
On Wed, Sep 13, 2017 at 11:38 AM, Luis R. Rodriguez wrote: >> Commit 06a45a93e7d34a seems to be a cleanup. The arguments in >> 06a45a93e7d3 ("firmware: move umh try locks into the umh code") seem >> valid, and there's no real reason to worry about that FW_OPT_NOWAIT >> etc for the direct-from-file

Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"

2017-09-13 Thread Luis R. Rodriguez
Rafeal a question for you below. On Tue, Sep 12, 2017 at 09:11:46PM -0700, Linus Torvalds wrote: > On Tue, Sep 12, 2017 at 5:47 PM, Greg Kroah-Hartman > wrote: > > > >> If reverting this commit please consider reverting also commit > >> 06a45a93e7d34a ("firmware: move umh try locks into the umh c

Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"

2017-09-12 Thread Linus Torvalds
On Tue, Sep 12, 2017 at 5:47 PM, Greg Kroah-Hartman wrote: > >> If reverting this commit please consider reverting also commit >> 06a45a93e7d34a ("firmware: move umh try locks into the umh code"). > > Ok, I can queue that revert up in my tree and will send it to Linus once > 4.14-rc1 is out. I wa

Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"

2017-09-12 Thread Greg Kroah-Hartman
On Wed, Sep 13, 2017 at 03:22:52AM +0200, Luis R. Rodriguez wrote: > On Tue, Sep 12, 2017 at 05:47:58PM -0700, Greg Kroah-Hartman wrote: > > On Tue, Sep 12, 2017 at 07:20:08PM +0200, Luis R. Rodriguez wrote: > > > On Tue, Sep 12, 2017 at 10:00:00AM -0700, Greg Kroah-Hartman wrote: > > > > 4.13-stab

Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"

2017-09-12 Thread Luis R. Rodriguez
On Tue, Sep 12, 2017 at 05:47:58PM -0700, Greg Kroah-Hartman wrote: > On Tue, Sep 12, 2017 at 07:20:08PM +0200, Luis R. Rodriguez wrote: > > On Tue, Sep 12, 2017 at 10:00:00AM -0700, Greg Kroah-Hartman wrote: > > > 4.13-stable review patch. If anyone has any objections, please let me > > > know.

Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"

2017-09-12 Thread Greg Kroah-Hartman
On Tue, Sep 12, 2017 at 07:20:08PM +0200, Luis R. Rodriguez wrote: > On Tue, Sep 12, 2017 at 10:00:00AM -0700, Greg Kroah-Hartman wrote: > > 4.13-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Linus Torvalds > > > > commit f007ca

Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"

2017-09-12 Thread Luis R. Rodriguez
On Tue, Sep 12, 2017 at 10:00:00AM -0700, Greg Kroah-Hartman wrote: > 4.13-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Linus Torvalds > > commit f007cad159e99fa2acd3b2e9364fbb32ad28b971 upstream. > > This reverts commit 81f95076281fd