Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-06-06 Thread Dave Martin
On Thu, Jun 06, 2019 at 10:34:22AM -0700, Yu-cheng Yu wrote: > On Thu, 2019-06-06 at 18:23 +0100, Dave Martin wrote: > > On Thu, Jun 06, 2019 at 06:11:56PM +0100, Catalin Marinas wrote: > > > On Fri, May 24, 2019 at 03:53:06PM +0100, Dave P Martin wrote: > > > > On Fri, May 24, 2019 at 02:02:17PM +

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-06-06 Thread Yu-cheng Yu
On Thu, 2019-06-06 at 18:23 +0100, Dave Martin wrote: > On Thu, Jun 06, 2019 at 06:11:56PM +0100, Catalin Marinas wrote: > > On Fri, May 24, 2019 at 03:53:06PM +0100, Dave P Martin wrote: > > > On Fri, May 24, 2019 at 02:02:17PM +0100, Mark Rutland wrote: > > > > On Fri, May 24, 2019 at 11:25:29AM

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-06-06 Thread Dave Martin
On Thu, Jun 06, 2019 at 06:11:56PM +0100, Catalin Marinas wrote: > On Fri, May 24, 2019 at 03:53:06PM +0100, Dave P Martin wrote: > > On Fri, May 24, 2019 at 02:02:17PM +0100, Mark Rutland wrote: > > > On Fri, May 24, 2019 at 11:25:29AM +0100, Dave Martin wrote: > > > > #endif /* _UAPI__ASM_HWCAP_

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-06-06 Thread Catalin Marinas
On Fri, May 24, 2019 at 03:53:06PM +0100, Dave P Martin wrote: > On Fri, May 24, 2019 at 02:02:17PM +0100, Mark Rutland wrote: > > On Fri, May 24, 2019 at 11:25:29AM +0100, Dave Martin wrote: > > > #endif /* _UAPI__ASM_HWCAP_H */ > > > diff --git a/arch/arm64/include/uapi/asm/mman.h > > > b/arch/

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-05-28 Thread Dave P Martin
On Fri, May 24, 2019 at 06:19:10PM +0100, Mark Rutland wrote: > On Fri, May 24, 2019 at 05:12:40PM +0100, Dave Martin wrote: > > On Fri, May 24, 2019 at 04:38:48PM +0100, Mark Rutland wrote: > > > On Fri, May 24, 2019 at 03:53:06PM +0100, Dave Martin wrote: > > > > On Fri, May 24, 2019 at 02:02:17P

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-05-24 Thread Mark Rutland
On Fri, May 24, 2019 at 05:12:40PM +0100, Dave Martin wrote: > On Fri, May 24, 2019 at 04:38:48PM +0100, Mark Rutland wrote: > > On Fri, May 24, 2019 at 03:53:06PM +0100, Dave Martin wrote: > > > On Fri, May 24, 2019 at 02:02:17PM +0100, Mark Rutland wrote: > > > > On Fri, May 24, 2019 at 11:25:29A

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-05-24 Thread Dave Martin
On Fri, May 24, 2019 at 04:38:48PM +0100, Mark Rutland wrote: > On Fri, May 24, 2019 at 03:53:06PM +0100, Dave Martin wrote: > > On Fri, May 24, 2019 at 02:02:17PM +0100, Mark Rutland wrote: > > > On Fri, May 24, 2019 at 11:25:29AM +0100, Dave Martin wrote: > > > > +#define arch_calc_vm_prot_bits(p

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-05-24 Thread Mark Rutland
On Fri, May 24, 2019 at 03:53:06PM +0100, Dave Martin wrote: > On Fri, May 24, 2019 at 02:02:17PM +0100, Mark Rutland wrote: > > On Fri, May 24, 2019 at 11:25:29AM +0100, Dave Martin wrote: > > > +#define arch_calc_vm_prot_bits(prot, pkey) arm64_calc_vm_prot_bits(prot) > > > +static inline unsigned

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-05-24 Thread Dave Martin
On Fri, May 24, 2019 at 02:02:17PM +0100, Mark Rutland wrote: > Hi Dave, > > This generally looks good, but I have a few comments below. > > On Fri, May 24, 2019 at 11:25:29AM +0100, Dave Martin wrote: > > +#define arch_calc_vm_prot_bits(prot, pkey) arm64_calc_vm_prot_bits(prot) > > +static inlin

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-05-24 Thread Mark Rutland
Hi Dave, This generally looks good, but I have a few comments below. On Fri, May 24, 2019 at 11:25:29AM +0100, Dave Martin wrote: > +#define arch_calc_vm_prot_bits(prot, pkey) arm64_calc_vm_prot_bits(prot) > +static inline unsigned long arm64_calc_vm_prot_bits(unsigned long prot) > +{ > + if