Re: [PATCH 4/6] zram: support idle page writeback

2018-11-22 Thread Minchan Kim
On Thu, Nov 22, 2018 at 03:59:26PM +0900, Sergey Senozhatsky wrote: > On (11/22/18 15:31), Minchan Kim wrote: > > > > > > I got what you mean now. Let's call it as "incompressible page wrieback" > > > to prevent confusing. > > > > > > "incompressible page writeback" would be orthgonal feature. Th

Re: [PATCH 4/6] zram: support idle page writeback

2018-11-21 Thread Sergey Senozhatsky
On (11/22/18 15:31), Minchan Kim wrote: > > > > I got what you mean now. Let's call it as "incompressible page wrieback" > > to prevent confusing. > > > > "incompressible page writeback" would be orthgonal feature. The goal is > > "let's save memory at the cost of *latency*". If the page is swapp

Re: [PATCH 4/6] zram: support idle page writeback

2018-11-21 Thread Minchan Kim
On Thu, Nov 22, 2018 at 03:15:42PM +0900, Minchan Kim wrote: > On Thu, Nov 22, 2018 at 02:40:40PM +0900, Sergey Senozhatsky wrote: > > On (11/22/18 14:04), Minchan Kim wrote: > > > > > > > additionally, it's too simple. It writes-back pages which can be > > > > swapped in immediately; which basica

Re: [PATCH 4/6] zram: support idle page writeback

2018-11-21 Thread Minchan Kim
On Thu, Nov 22, 2018 at 02:40:40PM +0900, Sergey Senozhatsky wrote: > On (11/22/18 14:04), Minchan Kim wrote: > > > > > additionally, it's too simple. It writes-back pages which can be > > > swapped in immediately; which basically means that we do pointless > > > PAGE_SIZE writes to a device which

Re: [PATCH 4/6] zram: support idle page writeback

2018-11-21 Thread Sergey Senozhatsky
On (11/22/18 14:04), Minchan Kim wrote: > > > additionally, it's too simple. It writes-back pages which can be > > swapped in immediately; which basically means that we do pointless > > PAGE_SIZE writes to a device which doesn't really like pointless > > writes. > > This patchset aims for *IDLE p

Re: [PATCH 4/6] zram: support idle page writeback

2018-11-21 Thread Minchan Kim
On Thu, Nov 22, 2018 at 11:14:43AM +0900, Sergey Senozhatsky wrote: > On (11/21/18 05:34), Minchan Kim wrote: > > > > > > Just a thought, > > > > > > I wonder if it will make sense (and if it will be possible) to writeback > > > idle _compressed_ objects. Right now we decompress, say, a perfectly

Re: [PATCH 4/6] zram: support idle page writeback

2018-11-21 Thread Sergey Senozhatsky
On (11/21/18 05:34), Minchan Kim wrote: > > > > Just a thought, > > > > I wonder if it will make sense (and if it will be possible) to writeback > > idle _compressed_ objects. Right now we decompress, say, a perfectly > > fine 400-byte compressed object to a PAGE_SIZE-d object and then push > > i

Re: [PATCH 4/6] zram: support idle page writeback

2018-11-21 Thread Minchan Kim
On Wed, Nov 21, 2018 at 01:55:51PM +0900, Sergey Senozhatsky wrote: > On (11/16/18 16:20), Minchan Kim wrote: > > + zram_set_flag(zram, index, ZRAM_UNDER_WB); > > + zram_slot_unlock(zram, index); > > + if (zram_bvec_read(zram, &bvec, index, 0, NULL)) { > > +

Re: [PATCH 4/6] zram: support idle page writeback

2018-11-20 Thread Sergey Senozhatsky
On (11/16/18 16:20), Minchan Kim wrote: > + zram_set_flag(zram, index, ZRAM_UNDER_WB); > + zram_slot_unlock(zram, index); > + if (zram_bvec_read(zram, &bvec, index, 0, NULL)) { > + zram_slot_lock(zram, index); > + zram_clea