Re: [PATCH 4/5] perf report: Fix dynamic entry display in hierarchy

2016-02-26 Thread Jiri Olsa
On Sat, Feb 27, 2016 at 12:12:08AM +0100, Jiri Olsa wrote: > On Fri, Feb 26, 2016 at 07:37:05PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 26, 2016 at 05:26:02PM -0500, Steven Rostedt escreveu: > > > On Fri, 26 Feb 2016 19:08:19 -0300 > > > Arnaldo Carvalho de Melo wrote: > > > > > >

Re: [PATCH 4/5] perf report: Fix dynamic entry display in hierarchy

2016-02-26 Thread Jiri Olsa
On Fri, Feb 26, 2016 at 07:37:05PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Feb 26, 2016 at 05:26:02PM -0500, Steven Rostedt escreveu: > > On Fri, 26 Feb 2016 19:08:19 -0300 > > Arnaldo Carvalho de Melo wrote: > > > > > > > It is exploding at this depth, not liking how gfp_flags is descr

Re: [PATCH 4/5] perf report: Fix dynamic entry display in hierarchy

2016-02-26 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2016 at 05:26:02PM -0500, Steven Rostedt escreveu: > On Fri, 26 Feb 2016 19:08:19 -0300 > Arnaldo Carvalho de Melo wrote: > > > > It is exploding at this depth, not liking how gfp_flags is described, > > problem > > seems to be in this function, this __print_flags() long thing.

Re: [PATCH 4/5] perf report: Fix dynamic entry display in hierarchy

2016-02-26 Thread Steven Rostedt
On Fri, 26 Feb 2016 19:08:19 -0300 Arnaldo Carvalho de Melo wrote: > It is exploding at this depth, not liking how gfp_flags is described, problem > seems to be in this function, this __print_flags() long thing. > > Steven, does this look familiar? > > Hmm, trace-cmd has the same issue. I jus

Re: [PATCH 4/5] perf report: Fix dynamic entry display in hierarchy

2016-02-26 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2016 at 07:08:19PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > print fmt: "call_site=%lx ptr=%p bytes_req=%zu bytes_alloc=%zu > > gfp_flags=%s", REC->call_site, REC->ptr, REC->bytes_req, REC->bytes_alloc, > > (REC->gfp_flags) ? __print_flags(REC->gfp_flags, "|", {(unsigned

Re: [PATCH 4/5] perf report: Fix dynamic entry display in hierarchy

2016-02-26 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2016 at 06:45:06PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 26, 2016 at 06:43:07PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Sat, Feb 27, 2016 at 03:52:46AM +0900, Namhyung Kim escreveu: > > > 37.50%0x8803f7669400 > > > 37.50%

Re: [PATCH 4/5] perf report: Fix dynamic entry display in hierarchy

2016-02-26 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2016 at 06:43:07PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sat, Feb 27, 2016 at 03:52:46AM +0900, Namhyung Kim escreveu: > > 37.50%0x8803f7669400 > > 37.50%448 > > 37.50%66080 > > 10.42%0x8803f766be00 >

Re: [PATCH 4/5] perf report: Fix dynamic entry display in hierarchy

2016-02-26 Thread Arnaldo Carvalho de Melo
Em Sat, Feb 27, 2016 at 03:52:46AM +0900, Namhyung Kim escreveu: > When dynamic sort key is used it might not show pretty printed output. > This is because the trace output was not set only for the first dynamic > sort key. During hierarchy_insert_entry() it missed to pass the > trace_output to dy