Re: [PATCH 4/5] PCI: qcom: Add Qualcomm PCIe controller driver

2015-01-12 Thread Bjorn Helgaas
On Fri, Dec 12, 2014 at 07:14:00PM +0200, Stanimir Varbanov wrote: > The PCIe driver reuse the Designware common code for host > and MSI initialization, and also program the Qualcomm > application specific registers. > > Signed-off-by: Stanimir Varbanov > --- > drivers/pci/host/Kconfig |

Re: [PATCH 4/5] PCI: qcom: Add Qualcomm PCIe controller driver

2014-12-16 Thread Arnd Bergmann
On Tuesday 16 December 2014 11:43:12 Stanimir Varbanov wrote: > >> +static int __init qcom_pcie_probe(struct platform_device *pdev) > >> +{ > > > > I think it's a bug to mark this function as __init. It breaks > > deferred probing and detaching/reattaching the device trough sysfs. > > > > My ba

Re: [PATCH 4/5] PCI: qcom: Add Qualcomm PCIe controller driver

2014-12-16 Thread Stanimir Varbanov
Hi Arnd, Thanks for the comments! On 12/12/2014 07:30 PM, Arnd Bergmann wrote: > On Friday 12 December 2014 19:14:00 Stanimir Varbanov wrote: >> The PCIe driver reuse the Designware common code for host >> and MSI initialization, and also program the Qualcomm >> application specific registers. >>

Re: [PATCH 4/5] PCI: qcom: Add Qualcomm PCIe controller driver

2014-12-12 Thread Arnd Bergmann
On Friday 12 December 2014 19:14:00 Stanimir Varbanov wrote: > The PCIe driver reuse the Designware common code for host > and MSI initialization, and also program the Qualcomm > application specific registers. > > Signed-off-by: Stanimir Varbanov Looks nice! > +static int > +qcom_pcie_rd_own_c