Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-08 Thread Sudeep Holla
On Wed, Oct 07, 2020 at 10:43:19AM -0500, Jassi Brar wrote: > On Wed, Oct 7, 2020 at 6:40 AM Sudeep Holla wrote: > > > > On Fri, Oct 02, 2020 at 02:42:37PM -0500, Jassi Brar wrote: > > > On Mon, Sep 28, 2020 at 6:45 AM Sudeep Holla wrote: > > > > > > > + > > > > +static void mhu_db_shutdown(struc

Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-07 Thread Jassi Brar
On Wed, Oct 7, 2020 at 6:40 AM Sudeep Holla wrote: > > On Fri, Oct 02, 2020 at 02:42:37PM -0500, Jassi Brar wrote: > > On Mon, Sep 28, 2020 at 6:45 AM Sudeep Holla wrote: > > > > > + > > > +static void mhu_db_shutdown(struct mbox_chan *chan) > > > +{ > > > + struct mhu_db_channel *chan_info

Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-07 Thread Sudeep Holla
On Wed, Oct 07, 2020 at 11:35:25AM +0530, Viresh Kumar wrote: > On 28-09-20, 12:44, Sudeep Holla wrote: > > The MHU drives the signal using a 32-bit register, with all 32 bits > > logically ORed together. The MHU provides a set of registers to enable > > software to set, clear, and check the status

Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-07 Thread Sudeep Holla
On Fri, Oct 02, 2020 at 02:42:37PM -0500, Jassi Brar wrote: > On Mon, Sep 28, 2020 at 6:45 AM Sudeep Holla wrote: > > > + > > +static void mhu_db_shutdown(struct mbox_chan *chan) > > +{ > > + struct mhu_db_channel *chan_info = chan->con_priv; > > + struct mbox_controller *mbox = &chan

Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-06 Thread Viresh Kumar
On 28-09-20, 12:44, Sudeep Holla wrote: > The MHU drives the signal using a 32-bit register, with all 32 bits > logically ORed together. The MHU provides a set of registers to enable > software to set, clear, and check the status of each of the bits of this > register independently. The use of 32 b

Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-02 Thread Jassi Brar
On Mon, Sep 28, 2020 at 6:45 AM Sudeep Holla wrote: > + > +static void mhu_db_shutdown(struct mbox_chan *chan) > +{ > + struct mhu_db_channel *chan_info = chan->con_priv; > + struct mbox_controller *mbox = &chan_info->mhu->mbox; > + int i; > + > + for (i = 0; i < mbox->num