Re: [PATCH 4/4] extcon: arizona: Eliminate dead error handling code

2013-11-12 Thread Chanwoo Choi
On 11/12/2013 11:30 PM, Charles Keepax wrote: > On Tue, Nov 12, 2013 at 09:15:29AM +0900, Chanwoo Choi wrote: >> Hi CHarles, >> >> On 11/08/2013 10:19 PM, Charles Keepax wrote: >>> As a small disclaimer I would personally prefer to not merge this patch. >>> I have added it based on previous code re

Re: [PATCH 4/4] extcon: arizona: Eliminate dead error handling code

2013-11-12 Thread Charles Keepax
On Tue, Nov 12, 2013 at 09:15:29AM +0900, Chanwoo Choi wrote: > Hi CHarles, > > On 11/08/2013 10:19 PM, Charles Keepax wrote: > > As a small disclaimer I would personally prefer to not merge this patch. > > I have added it based on previous code review of the other patches in > > this chain. > >

Re: [PATCH 4/4] extcon: arizona: Eliminate dead error handling code

2013-11-11 Thread Chanwoo Choi
Hi CHarles, On 11/08/2013 10:19 PM, Charles Keepax wrote: > As a small disclaimer I would personally prefer to not merge this patch. > I have added it based on previous code review of the other patches in > this chain. > > arizona_hpdet_do_id currently can only return 0 or -EAGAIN making the > el

Re: [PATCH 4/4] extcon: arizona: Eliminate dead error handling code

2013-11-11 Thread Charles Keepax
On Mon, Nov 11, 2013 at 09:00:14AM +, Lee Jones wrote: > > As a small disclaimer I would personally prefer to not merge this patch. > > I have added it based on previous code review of the other patches in > > this chain. > > I'd prefer the functionally redundant 'else if' over the comment. >

Re: [PATCH 4/4] extcon: arizona: Eliminate dead error handling code

2013-11-11 Thread Lee Jones
> As a small disclaimer I would personally prefer to not merge this patch. > I have added it based on previous code review of the other patches in > this chain. I'd prefer the functionally redundant 'else if' over the comment. I'm happy not to merge this patch. > arizona_hpdet_do_id currently ca