Re: [PATCH 37/50] tools/perf/build: Improve printout-of auto-detected features

2013-10-08 Thread Jiri Olsa
On Tue, Oct 08, 2013 at 10:46:10AM +0200, Ingo Molnar wrote: SNIP > So, this is a bit of a GNU Make mystery to me. If I have a failure for at > least one of the features, and if I leave out that DUMMY then I get this > printout: > > ... libperl: [ OFF ] > ...

Re: [PATCH 37/50] tools/perf/build: Improve printout-of auto-detected features

2013-10-08 Thread Ingo Molnar
* Jiri Olsa wrote: > On Mon, Oct 07, 2013 at 01:56:30PM +0200, Ingo Molnar wrote: > > SNIP > > > +# > > +# Only print out our features if we rebuilt the testcases or if a test > > failed: > > +# > > +ifeq ($(test-all-failed), 1) > > + $(foreach feat,$(CORE_FEATURE_TESTS) DUMMY,$(call feature

Re: [PATCH 37/50] tools/perf/build: Improve printout-of auto-detected features

2013-10-07 Thread Jiri Olsa
On Mon, Oct 07, 2013 at 01:56:30PM +0200, Ingo Molnar wrote: SNIP > +# > +# Only print out our features if we rebuilt the testcases or if a test > failed: > +# > +ifeq ($(test-all-failed), 1) > + $(foreach feat,$(CORE_FEATURE_TESTS) DUMMY,$(call feature_print,$(feat))) > + $(info ) > +endif f