Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Arnaldo Carvalho de Melo
Em Wed, May 20, 2015 at 09:56:25AM +0900, Namhyung Kim escreveu: > On Tue, May 19, 2015 at 09:22:10PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, May 20, 2015 at 08:56:58AM +0900, Namhyung Kim escreveu: > > > On Tue, May 19, 2015 at 05:18:54PM -0300, Arnaldo Carvalho de Melo wrote: > > > > E

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Namhyung Kim
On Tue, May 19, 2015 at 09:22:10PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, May 20, 2015 at 08:56:58AM +0900, Namhyung Kim escreveu: > > On Tue, May 19, 2015 at 05:18:54PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, May 19, 2015 at 09:49:03PM +0200, Jiri Olsa escreveu: > > > > > >

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Arnaldo Carvalho de Melo
Em Wed, May 20, 2015 at 08:56:58AM +0900, Namhyung Kim escreveu: > On Tue, May 19, 2015 at 05:18:54PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, May 19, 2015 at 09:49:03PM +0200, Jiri Olsa escreveu: > > > > > Humm, you're thinking about where you managed to reproduce the > > > > > problem,

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Namhyung Kim
On Tue, May 19, 2015 at 05:18:54PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, May 19, 2015 at 09:49:03PM +0200, Jiri Olsa escreveu: > > On Wed, May 20, 2015 at 12:12:45AM +0900, Namhyung Kim wrote: > > > > SNIP > > > > > > > > > > > > > > This looks reasonable, but I think it probably need

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Arnaldo Carvalho de Melo
Em Tue, May 19, 2015 at 09:49:03PM +0200, Jiri Olsa escreveu: > On Wed, May 20, 2015 at 12:12:45AM +0900, Namhyung Kim wrote: > > SNIP > > > > > > > > > > > This looks reasonable, but I think it probably needs to be done > > > > > somewhere in perf_evlist__prepare_workload() or > > > > > perf_ev

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Jiri Olsa
On Wed, May 20, 2015 at 12:12:45AM +0900, Namhyung Kim wrote: SNIP > > > > > > > > This looks reasonable, but I think it probably needs to be done > > > > somewhere in perf_evlist__prepare_workload() or > > > > perf_evlist__start_workload(), as this affects other tools as well, like > > > > 'top

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Arnaldo Carvalho de Melo
Em Wed, May 20, 2015 at 12:12:45AM +0900, Namhyung Kim escreveu: > On Tue, May 19, 2015 at 11:02:20AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, May 19, 2015 at 04:46:43PM +0900, Namhyung Kim escreveu: > > > On Mon, May 18, 2015 at 09:45:35AM -0300, Arnaldo Carvalho de Melo wrote: > > > > E

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Namhyung Kim
On Tue, May 19, 2015 at 11:02:20AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, May 19, 2015 at 04:46:43PM +0900, Namhyung Kim escreveu: > > On Mon, May 18, 2015 at 09:45:35AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, May 18, 2015 at 09:30:50AM +0900, Namhyung Kim escreveu: > > > > W

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Arnaldo Carvalho de Melo
Em Tue, May 19, 2015 at 04:46:43PM +0900, Namhyung Kim escreveu: > On Mon, May 18, 2015 at 09:45:35AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, May 18, 2015 at 09:30:50AM +0900, Namhyung Kim escreveu: > > > When perf creates a new child to profile, the events are enabled on > > > exec().

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-19 Thread Namhyung Kim
On Mon, May 18, 2015 at 09:45:35AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, May 18, 2015 at 09:30:50AM +0900, Namhyung Kim escreveu: > > When perf creates a new child to profile, the events are enabled on > > exec(). And in this case, it doesn't synthesize any event for the > > child since

Re: [PATCH 35/40] perf record: Synthesize COMM event for a command line workload

2015-05-18 Thread Arnaldo Carvalho de Melo
Em Mon, May 18, 2015 at 09:30:50AM +0900, Namhyung Kim escreveu: > When perf creates a new child to profile, the events are enabled on > exec(). And in this case, it doesn't synthesize any event for the > child since they'll be generated during exec(). But there's an window > between the enabling