Re: [PATCH 3.10] aio: restore locking of ioctx list on removal

2013-12-09 Thread Luis Henriques
On Fri, Dec 06, 2013 at 09:53:43AM -0500, Benjamin LaHaise wrote: > Hi Greg, Mateusz, > > On Fri, Dec 06, 2013 at 09:51:37AM +0100, Mateusz Guzik wrote: > > On Thu, Dec 05, 2013 at 05:03:47PM -0800, Greg KH wrote: > > > On Thu, Dec 05, 2013 at 11:09:02AM +0100, Mateusz Guzik wrote: > > > > Commit

Re: [PATCH 3.10] aio: restore locking of ioctx list on removal

2013-12-06 Thread Benjamin LaHaise
Hi Greg, Mateusz, On Fri, Dec 06, 2013 at 09:51:37AM +0100, Mateusz Guzik wrote: > On Thu, Dec 05, 2013 at 05:03:47PM -0800, Greg KH wrote: > > On Thu, Dec 05, 2013 at 11:09:02AM +0100, Mateusz Guzik wrote: > > > Commit 36f5588905c10a8c4568a210d601fe8c3c27e0f0 > > > "aio: refcounting cleanup" resu

Re: [PATCH 3.10] aio: restore locking of ioctx list on removal

2013-12-06 Thread Benjamin LaHaise
On Thu, Dec 05, 2013 at 05:03:47PM -0800, Greg KH wrote: > On Thu, Dec 05, 2013 at 11:09:02AM +0100, Mateusz Guzik wrote: > > Commit 36f5588905c10a8c4568a210d601fe8c3c27e0f0 > > "aio: refcounting cleanup" resulted in ioctx_lock not being held > > during ctx removal, leaving the list susceptible to

Re: [PATCH 3.10] aio: restore locking of ioctx list on removal

2013-12-06 Thread Mateusz Guzik
On Thu, Dec 05, 2013 at 05:03:47PM -0800, Greg KH wrote: > On Thu, Dec 05, 2013 at 11:09:02AM +0100, Mateusz Guzik wrote: > > Commit 36f5588905c10a8c4568a210d601fe8c3c27e0f0 > > "aio: refcounting cleanup" resulted in ioctx_lock not being held > > during ctx removal, leaving the list susceptible to

Re: [PATCH 3.10] aio: restore locking of ioctx list on removal

2013-12-05 Thread Greg KH
On Thu, Dec 05, 2013 at 11:09:02AM +0100, Mateusz Guzik wrote: > Commit 36f5588905c10a8c4568a210d601fe8c3c27e0f0 > "aio: refcounting cleanup" resulted in ioctx_lock not being held > during ctx removal, leaving the list susceptible to corruptions. > > In mainline kernel the issue went away as a sid