Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files v3

2014-07-10 Thread Andi Kleen
On Thu, Jul 10, 2014 at 08:25:08AM +0200, Jiri Olsa wrote: > On Thu, Jul 10, 2014 at 02:05:54AM +0200, Andi Kleen wrote: > > On Thu, Jul 10, 2014 at 12:19:58AM +0200, Jiri Olsa wrote: > > > Im confused, your branch shows v4 in patch Subject, > > > while this patch has v3... ? > > > > Patchkits and

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files v3

2014-07-09 Thread Jiri Olsa
On Thu, Jul 10, 2014 at 02:05:54AM +0200, Andi Kleen wrote: > On Thu, Jul 10, 2014 at 12:19:58AM +0200, Jiri Olsa wrote: > > Im confused, your branch shows v4 in patch Subject, > > while this patch has v3... ? > > Patchkits and patches both have their own numeric > version spaces. yes, but this

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files v3

2014-07-09 Thread Andi Kleen
> what happens if we fail to realloc? Then the field doesn't get added. No problem. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files v3

2014-07-09 Thread Andi Kleen
On Thu, Jul 10, 2014 at 12:19:58AM +0200, Jiri Olsa wrote: > Im confused, your branch shows v4 in patch Subject, > while this patch has v3... ? Patchkits and patches both have their own numeric version spaces. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files v3

2014-07-09 Thread Jiri Olsa
On Fri, Jun 27, 2014 at 04:15:58PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Add a parser for Intel style JSON event files. This allows > to use an Intel event list directly with perf. The Intel > event lists can be quite large and are too big to store > in unswappable kernel memory. > > T

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files v3

2014-07-09 Thread Jiri Olsa
Im confused, your branch shows v4 in patch Subject, while this patch has v3... ? jirka On Fri, Jun 27, 2014 at 04:15:58PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Add a parser for Intel style JSON event files. This allows > to use an Intel event list directly with perf. The Intel > event

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files v3

2014-07-09 Thread Jiri Olsa
On Fri, Jun 27, 2014 at 04:15:58PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Add a parser for Intel style JSON event files. This allows > to use an Intel event list directly with perf. The Intel > event lists can be quite large and are too big to store > in unswappable kernel memory. > > T

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files v3

2014-07-09 Thread Jiri Olsa
On Fri, Jun 27, 2014 at 04:15:58PM -0700, Andi Kleen wrote: > From: Andi Kleen SNIP > +} > diff --git a/tools/perf/util/jevents.h b/tools/perf/util/jevents.h > new file mode 100644 > index 000..4c2b879 > --- /dev/null > +++ b/tools/perf/util/jevents.h > @@ -0,0 +1,3 @@ missing standard '#if

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files

2014-05-15 Thread Andi Kleen
> And more generally, can we extend these if-else's to a generic loop to > check a table like in match_field() so that it can be added easily? The simple cases are all already handled in a table above. The if() only contains cases that need special code. I don't think callbacks would be better he

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files

2014-05-13 Thread Namhyung Kim
On Mon, 12 May 2014 15:51:08 -0700, Andi Kleen wrote: > From: Andi Kleen > > Add a parser for Intel style JSON event files. This allows > to use an Intel event list directly with perf. The Intel > event lists can be quite large and are too big to store > in unswappable kernel memory. > > The parse