Re: [PATCH 3/8] x86, microcode, intel: clarify log messages

2014-11-07 Thread Borislav Petkov
On Fri, Oct 31, 2014 at 06:08:02PM -0200, Henrique de Moraes Holschuh wrote: > In this case, it is useful churn IMHO: it is a building block that I used > immediately and that I will also need later for further improvements, it is > used to log that the early microcode driver failed due to an error

Re: [PATCH 3/8] x86, microcode, intel: clarify log messages

2014-10-31 Thread Henrique de Moraes Holschuh
On Wed, 29 Oct 2014, Borislav Petkov wrote: > On Tue, Oct 21, 2014 at 12:13:32PM -0200, Henrique de Moraes Holschuh wrote: > > > > @@ -178,11 +178,11 @@ static int apply_microcode_intel(int cpu) > > > > rdmsr(MSR_IA32_UCODE_REV, val[0], val[1]); > > > > > > > > if (val[1] != mc_in

Re: [PATCH 3/8] x86, microcode, intel: clarify log messages

2014-10-29 Thread Borislav Petkov
On Tue, Oct 21, 2014 at 12:13:32PM -0200, Henrique de Moraes Holschuh wrote: > > > @@ -178,11 +178,11 @@ static int apply_microcode_intel(int cpu) > > > rdmsr(MSR_IA32_UCODE_REV, val[0], val[1]); > > > > > > if (val[1] != mc_intel->hdr.rev) { > > > - pr_err("CPU%d update to revision 0

Re: [PATCH 3/8] x86, microcode, intel: clarify log messages

2014-10-21 Thread Henrique de Moraes Holschuh
On Mon, 20 Oct 2014, Borislav Petkov wrote: > On Mon, Sep 08, 2014 at 02:37:49PM -0300, Henrique de Moraes Holschuh wrote: > > The Intel microcode update driver will skip the second hardware thread > > on hyper-threaded cores during an update run, as the first hardware > > thread will have updated

Re: [PATCH 3/8] x86, microcode, intel: clarify log messages

2014-10-20 Thread Borislav Petkov
On Mon, Sep 08, 2014 at 02:37:49PM -0300, Henrique de Moraes Holschuh wrote: > The Intel microcode update driver will skip the second hardware thread > on hyper-threaded cores during an update run, as the first hardware > thread will have updated the entire core. This can confuse users, > because