Re: [PATCH 3/8] lib: bitmap: fold nbits into region struct

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 2:52 AM Yury Norov wrote: > On Wed, Jan 27, 2021 at 12:02 AM Paul Gortmaker > wrote: ... > > So, this change was added because Yury suggested that I "..store > > nmaskbits in the struct region, and avoid passing nmaskbits as a > > parameter." > > > > To which I originall

Re: [PATCH 3/8] lib: bitmap: fold nbits into region struct

2021-01-27 Thread Yury Norov
On Wed, Jan 27, 2021 at 12:02 AM Paul Gortmaker wrote: > > [Re: [PATCH 3/8] lib: bitmap: fold nbits into region struct] On 26/01/2021 > (Tue 23:16) Andy Shevchenko wrote: > > > On Tue, Jan 26, 2021 at 12:11:36PM -0500, Paul Gortmaker wrote: > > > This will reduce p

Re: [PATCH 3/8] lib: bitmap: fold nbits into region struct

2021-01-27 Thread Paul Gortmaker
[Re: [PATCH 3/8] lib: bitmap: fold nbits into region struct] On 26/01/2021 (Tue 23:16) Andy Shevchenko wrote: > On Tue, Jan 26, 2021 at 12:11:36PM -0500, Paul Gortmaker wrote: > > This will reduce parameter passing and enable using nbits as part > > of future dynamic region pa

Re: [PATCH 3/8] lib: bitmap: fold nbits into region struct

2021-01-26 Thread Yury Norov
On Tue, Jan 26, 2021 at 9:12 AM Paul Gortmaker wrote: > > This will reduce parameter passing and enable using nbits as part > of future dynamic region parameter parsing. > > Cc: Yury Norov > Cc: Rasmus Villemoes > Cc: Andy Shevchenko > Suggested-by: Yury Norov > Signed-off-by: Paul Gortmaker

Re: [PATCH 3/8] lib: bitmap: fold nbits into region struct

2021-01-26 Thread Andy Shevchenko
On Tue, Jan 26, 2021 at 11:16:25PM +0200, Andy Shevchenko wrote: > On Tue, Jan 26, 2021 at 12:11:36PM -0500, Paul Gortmaker wrote: > > This will reduce parameter passing and enable using nbits as part > > of future dynamic region parameter parsing. ... > > struct region r; > > long ret; >

Re: [PATCH 3/8] lib: bitmap: fold nbits into region struct

2021-01-26 Thread Andy Shevchenko
On Tue, Jan 26, 2021 at 12:11:36PM -0500, Paul Gortmaker wrote: > This will reduce parameter passing and enable using nbits as part > of future dynamic region parameter parsing. One nit below, nevertheless Reviewed-by: Andy Shevchenko > Cc: Yury Norov > Cc: Rasmus Villemoes > Cc: Andy Shevchen